Add SincResampler ported from WebKit.

media/base/sinc_resampler_unittest.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+// MSVC++ requires this to be set before any other includes to get M_PI.
+#define _USE_MATH_DEFINES
+
+#include <cmath>
+
+#include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/stringprintf.h"
+#include "media/base/sinc_resampler.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace media {
+
+// Chosen arbitrarily on what each resampler reported during testing.

[Ami GONE FROM CHROMIUM, 2012/06/30 20:29:30]

s/on/based on/

[DaleCurtis, 2012/07/03 00:36:34]

Done.

+static const double kMaxRMSError = 0.0002;

[Chris Rogers, 2012/07/02 20:38:14]

I'm not sure if the RMS error will be useful, but we can keep it

[DaleCurtis, 2012/07/03 00:36:34]

Happy to drop it, but I figured there would be cases where the max error may
stay the same, but average error may be higher.

+static const double kMaxError = 0.00022;

[Chris Rogers, 2012/07/02 20:38:14]

I'd represent this in decibels (actually dbFS) - so in this case
0.00022 <-> -73dBFS

since this is how this type of error is measured for audio

We might actually need two thresholds, one for lower frequencies (below about
0.9*Nyquist) and another more forgiving threshold for >0.9*Nyquist (we can talk
more about this when you get to this point)

+
+// Generate a swept sine wave with the given hertz over [0, kCycles * 2 * PI].
+class SweptSineSourceProvider : public SincResampler::AudioSourceProvider {
+ public:
+  // Maximum sine wave cycles.
+  static const int kCycles = 6;

[Chris Rogers, 2012/07/02 20:38:14]

As we discussed in chat, I think we should define specific starting and ending
frequencies.  The ending frequency will depend on the sample-rate
(source-sample-rate).  Because the values will vary depending on sample-rate, I
would make these be non-static member variable:

double min_frequency_;
double max_frequency_;

min_frequency_ can be initialized to a constant 5Hz (seems low enough).

max_frequency_ will be initialized to the Nyquist frequency = 0.5*sample_rate
(so sample_rate needs to be passed into the constructor and kept as a member
var)

We need to sweep the frequency all the way up to Nyquist to test how well the
resampler handles the very high frequencies.

[DaleCurtis, 2012/07/03 00:36:34]

Done.

+
+  // Hz/sec value for the swept sine wave.
+  // TODO(dalecurtis): Should we use a more complex pattern here?
+  static const int kHertzPerSecond = 1;

[Chris Rogers, 2012/07/02 20:38:14]

I don't think we'll need this constant.

[DaleCurtis, 2012/07/03 00:36:34]

Done.

+
+  explicit SweptSineSourceProvider(int max) {

[Chris Rogers, 2012/07/02 20:38:14]

"max"?  how about "sample_rate"

Then I'd simply get rid of ResetTimeState() and initialize the variables right
here.

[DaleCurtis, 2012/07/03 00:36:34]

Done.

+    ResetTimeState(max);
+  }
+
+  virtual ~SweptSineSourceProvider() {}
+
+  virtual void ProvideInput(float* destination, int number_of_frames) OVERRIDE {
+    for (int i = 0; i < number_of_frames; ++i) {
+      destination[i] = sin(kHertzPerSecond * time_state_ * time_state_);
+      time_state_ += time_increment_;
+    }
+  }
+
+  void ResetTimeState(int max) {
+    time_state_ = 0.0;
+    time_increment_ = kCycles * 2 * M_PI / max;
+  }
+
+ protected:
+  double hertz_;
+  double time_increment_;
+  double time_state_;
+
+  DISALLOW_COPY_AND_ASSIGN(SweptSineSourceProvider);
+};
+
+// Used for tests which just need to run without crashing or tooling errors, but
+// which may have undefined behavior for hashing, etc.

[Ami GONE FROM CHROMIUM, 2012/06/30 20:29:30]

wat?

[DaleCurtis, 2012/07/01 23:31:30]

Copy paste fail! (from ffmpeg_regression_tests)

[DaleCurtis, 2012/07/03 00:36:34]

Done.

+struct SincResamplerTestData {

[Ami GONE FROM CHROMIUM, 2012/06/30 20:29:30]

Isn't this kind of overkill for a std::pair<int, int> ?

[DaleCurtis, 2012/07/01 23:31:30]

Good point, I completely forgot about pair.

[DaleCurtis, 2012/07/03 00:36:34]

Switched to using tr1::tuple since gtest uses that internally and thus doesn't
require an ostream operator.

+  SincResamplerTestData(int input_rate, int output_rate)
+      : input_rate(input_rate),
+        output_rate(output_rate) {
+  }
+
+  std::string DebugString() const {

[Ami GONE FROM CHROMIUM, 2012/06/30 20:29:30]

FWIW, since this doesn't touch private data (there is none), you could drop this
and have the formatting go straight in the operator<<().

[DaleCurtis, 2012/07/03 00:36:34]

Removed with tuple().

+    return base::StringPrintf(
+      "Resampling test from %dHz to %dHz.", input_rate, output_rate);
+  }
+
+  const int input_rate;
+  const int output_rate;
+};
+
+class SincResamplerTestCase
+    : public testing::TestWithParam<SincResamplerTestData> {
+};
+
+// Define ostream << operator so GTest will print nice error messages instead of
+// "[...], where GetParam() = 8-byte object <44-AC 00-00 00-77 01-00>"
+::std::ostream& operator<<(::std::ostream& os,
+                           const SincResamplerTestData& data) {
+  return os << data.DebugString();
+}
+
+INSTANTIATE_TEST_CASE_P(

[Ami GONE FROM CHROMIUM, 2012/06/30 20:29:30]

Traditionally this goes *after* the test case it instantiates, not before.

[DaleCurtis, 2012/07/03 00:36:34]

Done.

+    SincResamplerTest, SincResamplerTestCase, testing::Values(
+        // To 44.1kHz
+        SincResamplerTestData(8000, 44100),

[Ami GONE FROM CHROMIUM, 2012/06/30 20:29:30]

Replace the explicit lists (which are prone to accidentally missing elements,
etc) with a testing::Combine() call?

[DaleCurtis, 2012/07/01 23:31:30]

Neat! I was looking for that.

[DaleCurtis, 2012/07/03 00:36:34]

Don't think we'll be able to use this since after talking to Chris we need each
conversion to check some specific error values. 

+        SincResamplerTestData(11025, 44100),
+        SincResamplerTestData(16000, 44100),
+        SincResamplerTestData(22050, 44100),
+        SincResamplerTestData(32000, 44100),
+        SincResamplerTestData(48000, 44100),
+        SincResamplerTestData(96000, 44100),
+        SincResamplerTestData(192000, 44100),
+
+        // To 48kHz
+        SincResamplerTestData(8000, 48000),
+        SincResamplerTestData(11025, 48000),
+        SincResamplerTestData(16000, 48000),
+        SincResamplerTestData(22050, 48000),
+        SincResamplerTestData(32000, 48000),
+        SincResamplerTestData(44100, 48000),
+        SincResamplerTestData(96000, 48000),
+        SincResamplerTestData(192000, 48000),
+
+        // To 96kHz
+        SincResamplerTestData(8000, 96000),
+        SincResamplerTestData(11025, 96000),
+        SincResamplerTestData(16000, 96000),
+        SincResamplerTestData(22050, 96000),
+        SincResamplerTestData(32000, 96000),
+        SincResamplerTestData(44100, 96000),
+        SincResamplerTestData(48000, 96000),
+        SincResamplerTestData(192000, 96000),
+
+        // To 192kHz
+        SincResamplerTestData(8000, 192000),
+        SincResamplerTestData(11025, 192000),
+        SincResamplerTestData(16000, 192000),
+        SincResamplerTestData(22050, 192000),
+        SincResamplerTestData(32000, 192000),
+        SincResamplerTestData(44100, 192000),
+        SincResamplerTestData(48000, 192000),
+        SincResamplerTestData(96000, 192000)));
+
+// Test callback() works as expected.
+TEST_P(SincResamplerTestCase, Resample) {
+  int input_rate = GetParam().input_rate;
+  int output_rate = GetParam().output_rate;
+
+  scoped_ptr<SweptSineSourceProvider> provider(

[Ami GONE FROM CHROMIUM, 2012/06/30 20:29:30]

hopefully you won't need this post-migration-to-CBs, but FYI this could have
been stack-allocated just as well (ditto for resampler below).

[DaleCurtis, 2012/07/03 00:36:34]

Done.

+      new SweptSineSourceProvider(input_rate));
+  scoped_ptr<SincResampler> resampler(new SincResampler(
+      provider.get(), static_cast<double>(input_rate) / output_rate));

[Ami GONE FROM CHROMIUM, 2012/06/30 20:29:30]

you could avoid this cast by making the input & output rates doubles in the
first place.

[DaleCurtis, 2012/07/03 00:36:34]

Then I need two casts for constructing the arrays.

+
+  // TODO(dalecurtis): These will need SSE appropriate allocations.

[Ami GONE FROM CHROMIUM, 2012/06/30 20:29:30]

Do you mean padding/alignment?  why not fix now?

[DaleCurtis, 2012/07/01 23:31:30]

Yes, but it's more than just here that needs to be changed. I also need to cook
up the AlignedData class first. Easier to do that all in one pass once this is
stable.

+  scoped_array<float> resampled_destination(new float[output_rate]);
+  scoped_array<float> pure_destination(new float[output_rate]);
+
+  // Generate resampled signal.
+  resampler->Resample(resampled_destination.get(), output_rate);

[Ami GONE FROM CHROMIUM, 2012/06/30 20:29:30]

It's confusing that output_rate is used for number_of_frames here.  Do you at
least want a clarifying intermediary
const int number_of_frames = output_rate;  // 1s worth of data.
or somesuch?

[DaleCurtis, 2012/07/03 00:36:34]

Done.

+
+  // Generate pure signal.
+  provider->ResetTimeState(output_rate);

[Chris Rogers, 2012/07/02 20:38:14]

Instead of re-using the existing object and exposing a public ResetTimeState()
method, I think it might be clearer to simply create a new provider:

scoped_ptr<SweptSineSourceProvider> pure_provider(
    new SweptSineSourceProvider(output_rate));

[DaleCurtis, 2012/07/03 00:36:34]

Done.

+  provider->ProvideInput(pure_destination.get(), output_rate);
+
+  // Calculate Root-Mean-Square-Error for the resampling.
+  double sum_of_squares = 0.0;

[Ami GONE FROM CHROMIUM, 2012/06/30 20:29:30]

.0 here and below unnecessary

[DaleCurtis, 2012/07/03 00:36:34]

Done.

+  double max_error = 0.0;
+  for (int i = 0; i < output_rate; ++i) {
+    double error = fabs(resampled_destination[i] - pure_destination[i]);
+    max_error = std::max(max_error, error);
+    sum_of_squares += error * error;
+  }
+
+  double rms_error = sqrt(sum_of_squares / output_rate);
+
+  // TODO(dalecurtis): Should this be different for each (in, out) pair?

[Ami GONE FROM CHROMIUM, 2012/06/30 20:29:30]

how wide is the spread?

[DaleCurtis, 2012/07/03 00:36:34]

rms error is about 0.17 -> 0.55, max: 0.86 -> 1.86. Chris and I are discussing
the best way to check all this now.

+  EXPECT_LT(rms_error, kMaxRMSError);
+  EXPECT_LT(max_error, kMaxError);
+}
+
+}  // namespace media