Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: content/common/child_thread.cc

Issue 10702048: Remove the code to wait on disconnected child processes to get the exit code. This was done in r101… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/child_thread.h" 5 #include "content/common/child_thread.h"
6 6
7 #include "base/allocator/allocator_extension.h" 7 #include "base/allocator/allocator_extension.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/process.h" 10 #include "base/process.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 channel_->AddFilter(new ChildTraceMessageFilter()); 63 channel_->AddFilter(new ChildTraceMessageFilter());
64 } 64 }
65 65
66 ChildThread::~ChildThread() { 66 ChildThread::~ChildThread() {
67 #ifdef IPC_MESSAGE_LOG_ENABLED 67 #ifdef IPC_MESSAGE_LOG_ENABLED
68 IPC::Logging::GetInstance()->SetIPCSender(NULL); 68 IPC::Logging::GetInstance()->SetIPCSender(NULL);
69 #endif 69 #endif
70 70
71 channel_->RemoveFilter(sync_message_filter_.get()); 71 channel_->RemoveFilter(sync_message_filter_.get());
72 72
73 // Close this channel before resetting the message loop attached to it so
74 // the message loop can call ChannelProxy::Context::OnChannelClosed(), which
75 // releases the reference count to this channel.
76 channel_->Close();
cpu_(ooo_6.6-7.5) 2012/07/09 05:14:11 dang. If I've seen this before...
77
78 // The ChannelProxy object caches a pointer to the IPC thread, so need to 73 // The ChannelProxy object caches a pointer to the IPC thread, so need to
79 // reset it as it's not guaranteed to outlive this object. 74 // reset it as it's not guaranteed to outlive this object.
80 // NOTE: this also has the side-effect of not closing the main IPC channel to 75 // NOTE: this also has the side-effect of not closing the main IPC channel to
81 // the browser process. This is needed because this is the signal that the 76 // the browser process. This is needed because this is the signal that the
82 // browser uses to know that this process has died, so we need it to be alive 77 // browser uses to know that this process has died, so we need it to be alive
83 // until this process is shut down, and the OS closes the handle 78 // until this process is shut down, and the OS closes the handle
84 // automatically. We used to watch the object handle on Windows to do this, 79 // automatically. We used to watch the object handle on Windows to do this,
85 // but it wasn't possible to do so on POSIX. 80 // but it wasn't possible to do so on POSIX.
86 channel_->ClearIPCMessageLoop(); 81 channel_->ClearIPCMessageLoop();
87 } 82 }
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 } 271 }
277 272
278 // The child process shutdown sequence is a request response based mechanism, 273 // The child process shutdown sequence is a request response based mechanism,
279 // where we send out an initial feeler request to the child process host 274 // where we send out an initial feeler request to the child process host
280 // instance in the browser to verify if it's ok to shutdown the child process. 275 // instance in the browser to verify if it's ok to shutdown the child process.
281 // The browser then sends back a response if it's ok to shutdown. This avoids 276 // The browser then sends back a response if it's ok to shutdown. This avoids
282 // race conditions if the process refcount is 0 but there's an IPC message 277 // race conditions if the process refcount is 0 but there's an IPC message
283 // inflight that would addref it. 278 // inflight that would addref it.
284 Send(new ChildProcessHostMsg_ShutdownRequest); 279 Send(new ChildProcessHostMsg_ShutdownRequest);
285 } 280 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698