chromeos: Fix pixelated icons in app list and launcher (part 2)

chrome/browser/extensions/app_shortcut_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/app_shortcut_manager.h"
 
 #include "base/command_line.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/web_applications/web_app.h"
@@ skipping 94 matching lines @@
   shortcut_info_.create_on_desktop = true;
   shortcut_info_.profile_path = profile_->GetPath();
 
   std::vector<ImageLoadingTracker::ImageInfo> info_list;
   for (size_t i = 0; i < arraysize(kDesiredSizes); ++i) {
     int size = kDesiredSizes[i];
     ExtensionResource resource = extension->GetIconResource(
         size, ExtensionIconSet::MATCH_EXACTLY);
     if (!resource.empty()) {
       info_list.push_back(
-          ImageLoadingTracker::ImageInfo(resource, gfx::Size(size, size)));
+          ImageLoadingTracker::ImageInfo(resource,
+                                         gfx::Size(size, size),
+                                         ui::SCALE_FACTOR_NONE));

[pkotwicz, 2012/07/16 17:33:52]

ui::SCALE_FACTOR_100P

[xiyuan, 2012/07/16 20:11:27]

Changed but AppShortcutManager loads multi-resolution images to create an icon
out of it and does not care DIP. Shoudn't SCALE_FACTOR_NONE sounds more correct
in this sense?

     }
   }
 
   if (info_list.empty()) {
     size_t i = arraysize(kDesiredSizes) - 1;
     int size = kDesiredSizes[i];
 
     // If there is no icon at the desired sizes, we will resize what we can get.
     // Making a large icon smaller is prefered to making a small icon larger, so
     // look for a larger icon first:
     ExtensionResource resource = extension->GetIconResource(
         size, ExtensionIconSet::MATCH_BIGGER);
     if (resource.empty()) {
       resource = extension->GetIconResource(
           size, ExtensionIconSet::MATCH_SMALLER);
     }
     info_list.push_back(
-        ImageLoadingTracker::ImageInfo(resource, gfx::Size(size, size)));
+        ImageLoadingTracker::ImageInfo(resource,
+                                       gfx::Size(size, size),
+                                       ui::SCALE_FACTOR_NONE));

[pkotwicz, 2012/07/16 17:33:52]

Change this to ui::SCALE_FACTOR_100P

[xiyuan, 2012/07/16 20:11:27]

Done.

   }
 
   // |icon_resources| may still be empty at this point, in which case LoadImage
   // will call the OnImageLoaded callback with an empty image and exit
   // immediately.
   tracker_.LoadImages(extension, info_list, ImageLoadingTracker::DONT_CACHE);
 }