chrome/renderer/print_web_view_helper.cc - Issue 10701063: Cleanup gfx::Canvas now that 10562027 has landed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/print_web_view_helper.cc

Issue 10701063: Cleanup gfx::Canvas now that 10562027 has landed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/print_web_view_helper.cc

diff --git a/chrome/renderer/print_web_view_helper.cc b/chrome/renderer/print_web_view_helper.cc

index 79c4e4751ef7cd4b1e9acb570018287f0240d407..c425877f47ee3b92c1e677f62320bd00d7ae2479 100644

--- a/chrome/renderer/print_web_view_helper.cc

+++ b/chrome/renderer/print_web_view_helper.cc

@@ -453,8 +453,9 @@ void PrintHeaderFooterText(

SkMatrix m = canvas->getTotalMatrix();

ui::ScaleFactor device_scale_factor = ui::GetScaleFactorFromScale(

SkScalarAbs(m.getScaleX()));

- gfx::Canvas gfx_canvas(canvas, device_scale_factor, false);

- paint->Draw(&gfx_canvas);

+ scoped_ptr<gfx::Canvas> gfx_canvas(gfx::Canvas::CreateCanvasWithoutScaling(

+ canvas, device_scale_factor));

+ paint->Draw(gfx_canvas.get());

}

#else

// TODO(arthurhsu): following code has issues with i18n BiDi, see