Cleanup gfx::Canvas now that 10562027 has landed

ui/gfx/canvas.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_CANVAS_H_
 #define UI_GFX_CANVAS_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 82 matching lines @@
 
     // Instructs DrawStringInt() to not use subpixel rendering.  This is useful
     // when rendering text onto a fully- or partially-transparent background
     // that will later be blended with another image.
     NO_SUBPIXEL_RENDERING = 1 << 13,
   };
 
   // Creates an empty canvas with scale factor of 1x.
   Canvas();
 
-  // Creates canvas with provided DIP |size| and a scale factor of 1x.
-  // If this canvas is not opaque, it's explicitly cleared to transparent before
-  // being returned.
-  // TODO(pkotwicz): Remove this constructor.
-  Canvas(const gfx::Size& size, bool is_opaque);
-
   // Creates canvas with provided DIP |size| and |scale_factor|.
   // If this canvas is not opaque, it's explicitly cleared to transparent before
   // being returned.
   Canvas(const gfx::Size& size,
          ui::ScaleFactor scale_factor,
          bool is_opaque);
 
   // Constructs a canvas with the size and the scale factor of the
   // provided |image_rep|, and draws the |image_rep| into it.
   Canvas(const gfx::ImageSkiaRep& image_rep, bool is_opaque);
 
-  // Sets scale factor to |scale_factor|.
-  // Only scales canvas if |scale_canvas| is true.
-  Canvas(SkCanvas* canvas,
-         ui::ScaleFactor scale_factor,
-         bool scale_canvas);
+  virtual ~Canvas();
 
-  virtual ~Canvas();
+  // Creates a gfx::Canvas backed by an |sk_canvas| with |scale_factor|.
+  // |sk_canvas| is assumed to be already scaled based on |scale_factor|
+  // so no additional scaling is applied.
+  static Canvas* CreateCanvasWithoutScaling(SkCanvas* sk_canvas,
+                                            ui::ScaleFactor scale_factor);
 
   // Recreates the backing platform canvas with DIP |size| and |scale_factor|.
   // If the canvas is not opaque, it is explicitly cleared.
   // This method is public so that canvas_skia_paint can recreate the platform
   // canvas after having initialized the canvas.
   // TODO(pkotwicz): Push the scale factor into skia::PlatformCanvas such that
   // this method can be private.
   void RecreateBackingCanvas(const gfx::Size& size,
                              ui::ScaleFactor scale_factor,
                              bool is_opaque);
@@ skipping 29 matching lines @@
   // On Mac, NOTIMPLEMENTED.
   //   TODO(dhollowa): Skia-native implementation is underway.  Cut over to
   //   that when ready.  http::/crbug.com/109946
   void DrawStringWithHalo(const string16& text,
                           const gfx::Font& font,
                           SkColor text_color,
                           SkColor halo_color,
                           int x, int y, int w, int h,
                           int flags);
 
-  // Extracts a bitmap from the contents of this canvas.
-  // TODO(pkotwicz): Remove ExtractBitmap once all callers use
-  // ExtractImageSkiaRep instead.
-  SkBitmap ExtractBitmap() const;
-
   // Extracts an ImageSkiaRep from the contents of this canvas.
-  gfx::ImageSkiaRep ExtractImageSkiaRep() const;
+  gfx::ImageSkiaRep ExtractImageRep() const;
 
   // Draws a dashed rectangle of the specified color.
   void DrawDashedRect(const gfx::Rect& rect, SkColor color);
 
   // Saves a copy of the drawing state onto a stack, operating on this copy
   // until a balanced call to Restore() is made.
   void Save();
 
   // As with Save(), except draws to a layer that is blended with the canvas
   // at the specified alpha once Restore() is called.
@@ skipping 189 matching lines @@
       size_t desired_characters_to_truncate_from_head,
       const gfx::Font& font,
       SkColor color,
       const gfx::Rect& display_rect);
 
   skia::PlatformCanvas* platform_canvas() const { return owned_canvas_.get(); }
   SkCanvas* sk_canvas() const { return canvas_; }
   ui::ScaleFactor scale_factor() const { return scale_factor_; }
 
  private:
+  Canvas(SkCanvas* canvas, ui::ScaleFactor scale_factor);
+
   // Test whether the provided rectangle intersects the current clip rect.
   bool IntersectsClipRectInt(int x, int y, int w, int h);
   bool IntersectsClipRect(const gfx::Rect& rect);
 
-  // Sets the canvas' scale factor to |scale_factor|. This affects
-  // the scale factor at which drawing bitmaps occurs and the scale factor of
-  // the image rep returned by Canvas::ExtractImageSkiaRep().
-  // If |scale_canvas| is true, scales the canvas by |scale_factor|.
-  void ApplyScaleFactor(ui::ScaleFactor scale_factor, bool scale_canvas);
-
   // Returns the image rep which best matches the canvas |scale_factor_|.
   // Returns a null image rep if |image| contains no image reps.
   // Builds mip map for returned image rep if necessary.
   //
   // An optional additional user defined scale can be provided.
   const gfx::ImageSkiaRep& GetImageRepToPaint(
       const gfx::ImageSkia& image) const;
   const gfx::ImageSkiaRep& GetImageRepToPaint(
       const gfx::ImageSkia& image,
       float user_defined_scale_factor_x,
       float user_defined_scale_factor_y)  const;
 
-  scoped_ptr<skia::PlatformCanvas> owned_canvas_;
-  SkCanvas* canvas_;
-
-  // True if the scale factor scales the canvas and the inverse
-  // canvas scale should be applied when the destructor is called.
-  bool scale_factor_scales_canvas_;
-
   // The device scale factor at which drawing on this canvas occurs.
   // An additional scale can be applied via Canvas::Scale(). However,
   // Canvas::Scale() does not affect |scale_factor_|.
   ui::ScaleFactor scale_factor_;
 
+  scoped_ptr<skia::PlatformCanvas> owned_canvas_;
+  SkCanvas* canvas_;
+
   DISALLOW_COPY_AND_ASSIGN(Canvas);
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_CANVAS_H_