content/browser/download/base_file.cc - Issue 10701050: net: Implement canceling of all async operations in FileStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/base_file.cc

Issue 10701050: net: Implement canceling of all async operations in FileStream. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Update after http://crrev.com/159454 Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/base_file.cc

diff --git a/content/browser/download/base_file.cc b/content/browser/download/base_file.cc

index cc7871fcedde3d1a34ba8488651b4e4f96a7b20a..1549ceb2986f9d2800de4ace221eb02cbccfe077 100644

--- a/content/browser/download/base_file.cc

+++ b/content/browser/download/base_file.cc

@@ -417,7 +417,8 @@ void BaseFile::Cancel() {

if (!full_path_.empty()) {

bound_net_log_.AddEvent(net::NetLog::TYPE_DOWNLOAD_FILE_DELETED);

- file_util::Delete(full_path_, false);

+ bool deleted = file_util::Delete(full_path_, false);

+ DCHECK(deleted);

}

@@ -529,7 +530,6 @@ void BaseFile::Close() {

// theres not much we can do. But we might in the future.

file_stream_->FlushSync();

#endif

- file_stream_->CloseSync();

ClearStream(net::OK);

}