net: Implement canceling of all async operations in FileStream.

chromeos/dbus/debug_daemon_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <fcntl.h>
 #include <unistd.h>
 
 #include "chromeos/dbus/debug_daemon_client.h"
 
 #include "base/bind.h"
@@ skipping 32 matching lines @@
   typedef base::Callback<void(void)>IOCompleteCallback;
 
   explicit PipeReader(IOCompleteCallback callback)
       : data_stream_(NULL),
         io_buffer_(new net::IOBufferWithSize(4096)),
         callback_(callback),
         weak_ptr_factory_(this) {
     pipe_fd_[0] = pipe_fd_[1] = -1;
   }
 
   virtual ~PipeReader() {

[satorux1, 2012/11/05 05:30:37]

I'd suggest to leave a comment:

// Don't close pipe_fd_[0] as it's closed by data_stream_.

-    if (pipe_fd_[0] != -1)
-      if (HANDLE_EINTR(close(pipe_fd_[0])) < 0)
-        PLOG(ERROR) << "close[0]";
     if (pipe_fd_[1] != -1)
       if (HANDLE_EINTR(close(pipe_fd_[1])) < 0)
         PLOG(ERROR) << "close[1]";
   }
 
   // Returns descriptor for the writeable side of the pipe.
   int GetWriteFD() { return pipe_fd_[1]; }
 
   // Closes writeable descriptor; normally used in parent process after fork.
   void CloseWriteFD() {
@@ skipping 495 matching lines @@
 // static
 DebugDaemonClient* DebugDaemonClient::Create(DBusClientImplementationType type,
                                    dbus::Bus* bus) {
   if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)
     return new DebugDaemonClientImpl(bus);
   DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);
   return new DebugDaemonClientStubImpl();
 }
 
 }  // namespace chromeos