sync: Remove SyncManager::TestingMode in favour of InternalComponentsFactory.

sync/internal_api/public/sync_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_INTERNAL_API_PUBLIC_SYNC_MANAGER_H_
 #define SYNC_INTERNAL_API_PUBLIC_SYNC_MANAGER_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/callback_forward.h"
 #include "base/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/task_runner.h"
 #include "base/threading/thread_checker.h"
 #include "base/time.h"
 #include "sync/internal_api/public/base/model_type.h"
 #include "sync/internal_api/public/change_record.h"
 #include "sync/internal_api/public/configure_reason.h"
 #include "sync/internal_api/public/engine/model_safe_worker.h"
 #include "sync/internal_api/public/engine/sync_status.h"
+#include "sync/internal_api/public/internal_components_factory.h"

[Nicolas Zea, 2012/07/18 21:10:12]

forward declare?

[tim (not reviewing), 2012/07/18 21:57:47]

Done.

 #include "sync/internal_api/public/util/report_unrecoverable_error_function.h"
 #include "sync/internal_api/public/util/unrecoverable_error_handler.h"

[Nicolas Zea, 2012/07/18 21:10:12]

this can be forward declared too I think

[tim (not reviewing), 2012/07/18 21:57:47]

Done.

 #include "sync/internal_api/public/util/weak_handle.h"
 #include "sync/protocol/sync_protocol_error.h"
 
 namespace syncer {
 class Encryptor;
 struct Experiments;
 class ExtensionsActivityMonitor;
 class JsBackend;
 class JsEventHandler;
 class SyncScheduler;
@@ skipping 299 matching lines @@
     // Called from within a transaction.
     virtual void OnEncryptionComplete() = 0;
 
     virtual void OnActionableError(
         const syncer::SyncProtocolError& sync_protocol_error) = 0;
 
    protected:
     virtual ~Observer();
   };
 
-  enum TestingMode {
-    NON_TEST,
-    TEST_ON_DISK,
-    TEST_IN_MEMORY,
-  };
-
   // Create an uninitialized SyncManager.  Callers must Init() before using.
   explicit SyncManager(const std::string& name);
   virtual ~SyncManager();
 
   // Initialize the sync manager.  |database_location| specifies the path of
   // the directory in which to locate a sqlite repository storing the syncer
   // backend state. Initialization will open the database, or create it if it
   // does not already exist. Returns false on failure.
   // |event_handler| is the JsEventHandler used to propagate events to
   // chrome://sync-internals.  |event_handler| may be uninitialized.
@@ skipping 21 matching lines @@
             const scoped_refptr<base::TaskRunner>& blocking_task_runner,
             HttpPostProviderFactory* post_factory,
             const syncer::ModelSafeRoutingInfo& model_safe_routing_info,
             const std::vector<syncer::ModelSafeWorker*>& workers,
             syncer::ExtensionsActivityMonitor*
                 extensions_activity_monitor,
             ChangeDelegate* change_delegate,
             const SyncCredentials& credentials,
             syncer::SyncNotifier* sync_notifier,
             const std::string& restored_key_for_bootstrapping,
-            TestingMode testing_mode,
+            scoped_ptr<InternalComponentsFactory> internal_components_factory,
             syncer::Encryptor* encryptor,
             syncer::UnrecoverableErrorHandler*
                 unrecoverable_error_handler,
             syncer::ReportUnrecoverableErrorFunction
                 report_unrecoverable_error_function);
 
   // Throw an unrecoverable error from a transaction (mostly used for
   // testing).
   void ThrowUnrecoverableError();
 
@@ skipping 169 matching lines @@
 bool InitialSyncEndedForTypes(syncer::ModelTypeSet types, UserShare* share);
 
 const char* ConnectionStatusToString(ConnectionStatus status);
 
 // Returns the string representation of a PassphraseRequiredReason value.
 const char* PassphraseRequiredReasonToString(PassphraseRequiredReason reason);
 
 }  // namespace syncer
 
 #endif  // SYNC_INTERNAL_API_PUBLIC_SYNC_MANAGER_H_