Use JSON schema compiler for i18n api

Use JSON schema compiler in i18n API code

TBR=ben@chromium.org

BUG=121174
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149045

[not at google - send to devlin, 2012-06-29 04:58:00]

The TEST= line is for when a patch fixes a bug, and test people come along to do
the test and verify it's fixed; so don't need to have it here.

lgtm for what you have, but if you feel like cleaning up the code too (as I
mentioned) then I'd like to take a look at that.

http://codereview.chromium.org/10701026/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_i18n_api.cc (right):

http://codereview.chromium.org/10701026/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_i18n_api.cc:23: string16 acceptLanguages =
Style should be accept_languages not acceptLanguages.

http://codereview.chromium.org/10701026/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_i18n_api.cc:41: std::vector<std::string>
languages_vec;
just "languages"?

http://codereview.chromium.org/10701026/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_i18n_api.cc:54: }
This code should be using base::SplitString (base/string_split.h) on
accept_langauges with ',', filtering out empty strings (e.g. using
std::remove_if or some other stl function I'm not aware of), then returning an
error if it's empty.

However I don't think the goal of this patch is to cleanup messy code :) so if
you don't feel like changing it, don't worry about it.

[mitchellwrosen, 2012-07-27 23:51:41]

This fell off the radar, sorry! LGTM still stands I assume? Feel free to
critique my clean up using StringSplit. I'll commit in a couple days if I don't
hear from you.

http://codereview.chromium.org/10701026/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_i18n_api.cc (right):

http://codereview.chromium.org/10701026/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_i18n_api.cc:41: std::vector<std::string>
languages_vec;
On 2012/06/29 04:58:00, kalman wrote:
> just "languages"?

Done.

[not at google - send to devlin, 2012-07-30 11:35:47]

lgtm

http://codereview.chromium.org/10701026/diff/5001/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_i18n_api.cc (right):

http://codereview.chromium.org/10701026/diff/5001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_i18n_api.cc:26:
UTF8ToUTF16(profile()->GetPrefs()->GetString(prefs::kAcceptLanguages));
This is weird that we convert from utf8 to utf16 then later back to UT8 again.
I've had a C++ expert standing over explaining the intricacies of all of this,
and it looks like you can basically cut out all references to utf16, which will
cut down even more on the amount of code.

http://codereview.chromium.org/10701026/diff/5001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_i18n_api.cc:53: languages_utf8.erase(iter,
languages_utf8.end());
perhaps inline iter? Unless there's some strange C++ reason why you can't.

[mitchellwrosen, 2012-07-30 17:56:05]

+mpcomplete for chrome/

http://codereview.chromium.org/10701026/diff/5001/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_i18n_api.cc (right):

http://codereview.chromium.org/10701026/diff/5001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_i18n_api.cc:26:
UTF8ToUTF16(profile()->GetPrefs()->GetString(prefs::kAcceptLanguages));
On 2012/07/30 11:35:47, kalman wrote:
> This is weird that we convert from utf8 to utf16 then later back to UT8 again.
> I've had a C++ expert standing over explaining the intricacies of all of this,
> and it looks like you can basically cut out all references to utf16, which
will
> cut down even more on the amount of code.

Done.

http://codereview.chromium.org/10701026/diff/5001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_i18n_api.cc:53: languages_utf8.erase(iter,
languages_utf8.end());
On 2012/07/30 11:35:47, kalman wrote:
> perhaps inline iter? Unless there's some strange C++ reason why you can't.

Done.

[not at google - send to devlin, 2012-07-30 18:40:02]

mpcomplete isn't a chrome owner, but TBR one of the owners in chrome/OWNERS
(whoever is first) since it's just a gyp change. It's what you're supposed to do
these days.

[commit-bot: I haz the power, 2012-07-30 18:42:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10701026/9001

[commit-bot: I haz the power, 2012-07-30 22:10:23]

Change committed as 149045