Fix eliding of LTR tab title in RTL UI under non-Windows Views.

chrome/browser/ui/views/tabs/base_tab.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tabs/base_tab.h"
 
 #include <limits>
 
 #include "base/command_line.h"
 #include "base/utf_string_conversions.h"
@@ skipping 529 matching lines @@
         l10n_util::GetStringUTF16(IDS_TAB_LOADING_TITLE) :
         CoreTabHelper::GetDefaultTitle();
   } else {
     Browser::FormatTitleForDisplay(&title);
   }
 
 #if defined(OS_WIN)
   canvas->DrawFadeTruncatingString(title, gfx::Canvas::TruncateFadeTail, 0,
                                    *font_, title_color, title_bounds);
 #else
+  int flags = gfx::Canvas::TEXT_ALIGN_LEFT;
+  if (base::i18n::IsRTL() &&
+      base::i18n::GetFirstStrongCharacterDirection(title) !=
+          base::i18n::LEFT_TO_RIGHT) {
+    flags = gfx::Canvas::TEXT_ALIGN_RIGHT;
+  }

[xji, 2012/06/29 18:11:24]

Since RenderText has both directionality and horizotal aligment information, can
we not pass information here and do fading/truncation inside RenderText by
querying its directionality and alignment information?

   canvas->DrawStringInt(title, *font_, title_color,
                         title_bounds.x(), title_bounds.y(),
-                        title_bounds.width(), title_bounds.height());
+                        title_bounds.width(), title_bounds.height(), flags);
 #endif
 }
 
 void BaseTab::AnimationProgressed(const ui::Animation* animation) {
   // Ignore if the pulse animation is being performed on active tab because
   // it repaints the same image. See |Tab::PaintTabBackground()|.
   if (animation == pulse_animation_.get() && IsActive())
     return;
   SchedulePaint();
 }
@@ skipping 75 matching lines @@
 // static
 void BaseTab::InitResources() {
   static bool initialized = false;
   if (!initialized) {
     initialized = true;
     ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
     font_ = new gfx::Font(rb.GetFont(ui::ResourceBundle::BaseFont));
     font_height_ = font_->GetHeight();
   }
 }