Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_keybinding_registry.h

Issue 10701005: Extension Commands changed by the user now take effect immediately. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/commands/command_service.cc ('k') | chrome/browser/extensions/extension_keybinding_registry.cc » ('j') | chrome/browser/extensions/extension_keybinding_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_keybinding_registry.h
===================================================================
--- chrome/browser/extensions/extension_keybinding_registry.h (revision 144430)
+++ chrome/browser/extensions/extension_keybinding_registry.h (working copy)
@@ -40,10 +40,12 @@
protected:
// Add extension keybinding for the events defined by the |extension|.
Yoyo Zhou 2012/06/28 22:40:51 Comments need to be updated.
Finnur 2012/06/28 22:49:01 Ah, right! On 2012/06/28 22:40:51, Yoyo Zhou wro
virtual void AddExtensionKeybinding(
- const Extension* extension) = 0;
+ const Extension* extension,
+ const std::string& command_name) = 0;
// Remove extension bindings for |extension|.
virtual void RemoveExtensionKeybinding(
- const Extension* extension) = 0;
+ const Extension* extension,
+ const std::string& command_name) = 0;
// Make sure all extensions registered have keybindings added.
void Init();
« no previous file with comments | « chrome/browser/extensions/api/commands/command_service.cc ('k') | chrome/browser/extensions/extension_keybinding_registry.cc » ('j') | chrome/browser/extensions/extension_keybinding_registry.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698