Extension Commands changed by the user now take effect immediately.

chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.h"
 
 #include "chrome/browser/extensions/api/commands/command_service.h"
 #include "chrome/browser/extensions/api/commands/command_service_factory.h"
 #include "chrome/browser/extensions/extension_browser_event_router.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 36 matching lines @@
     return FALSE;
 
   ui::AcceleratorGtk accelerator(ui::WindowsKeyCodeForGdkKeyCode(event->keyval),
                                  event->state & GDK_SHIFT_MASK,
                                  event->state & GDK_CONTROL_MASK,
                                  event->state & GDK_MOD1_MASK);
   return event_targets_.find(accelerator) != event_targets_.end();
 }
 
 void ExtensionKeybindingRegistryGtk::AddExtensionKeybinding(
-    const extensions::Extension* extension) {
+    const extensions::Extension* extension,
+    const std::string& command_name) {
   extensions::CommandService* command_service =
       extensions::CommandServiceFactory::GetForProfile(profile_);
   extensions::CommandMap commands;
   if (!command_service->GetNamedCommands(
           extension->id(),
           extensions::CommandService::ACTIVE_ONLY,
           &commands)) {
     return;
   }
 
   extensions::CommandMap::const_iterator iter = commands.begin();

[Evan Stade, 2012/06/29 18:39:07]

this should be inside the for statement

   for (; iter != commands.end(); ++iter) {
+    if (!command_name.empty() && (iter->second.command_name() != command_name))

[Yoyo Zhou, 2012/06/28 22:40:51]

Would it make any sense to do this instead in GetNamedCommands?

[Finnur, 2012/06/28 22:49:01]

Maybe. I'll take a look tomorrow. If it does I might choose to do this as a
followup CL. 

On 2012/06/28 22:40:51, Yoyo Zhou wrote:

+      continue;
+
     ui::AcceleratorGtk accelerator(iter->second.accelerator().key_code(),
                                    iter->second.accelerator().IsShiftDown(),
                                    iter->second.accelerator().IsCtrlDown(),
                                    iter->second.accelerator().IsAltDown());
     event_targets_[accelerator] =
         std::make_pair(extension->id(), iter->second.command_name());
 
     if (!accel_group_) {
       accel_group_ = gtk_accel_group_new();
       gtk_window_add_accel_group(window_, accel_group_);
@@ skipping 33 matching lines @@
     ui::AcceleratorGtk accelerator(page_action.accelerator().key_code(),
                                    page_action.accelerator().IsShiftDown(),
                                    page_action.accelerator().IsCtrlDown(),
                                    page_action.accelerator().IsAltDown());
     event_targets_[accelerator] =
         std::make_pair(extension->id(), page_action.command_name());
   }
 }
 
 void ExtensionKeybindingRegistryGtk::RemoveExtensionKeybinding(
-    const extensions::Extension* extension) {
+    const extensions::Extension* extension,
+    const std::string& command_name) {
   EventTargets::iterator iter = event_targets_.begin();
   while (iter != event_targets_.end()) {
-    if (iter->second.first != extension->id()) {
+    if (iter->second.first != extension->id() ||
+        (!command_name.empty() && (iter->second.second != command_name))) {

[Evan Stade, 2012/06/29 18:39:07]

don't need these parens around the != clause

       ++iter;
-      continue;  // Not the extension we asked for.
+      continue;  // Not the extension or command we asked for.
     }
 
     // On GTK, unlike Windows, the Event Targets contain all events but we must
     // only unregister the ones we own.
     if (ShouldIgnoreCommand(iter->second.second)) {
       ++iter;
       continue;
     }
 
     gtk_accel_group_disconnect_key(accel_group_,
@@ skipping 17 matching lines @@
   if (it == event_targets_.end()) {
     NOTREACHED();  // Shouldn't get this event for something not registered.
     return FALSE;
   }
 
   service->browser_event_router()->CommandExecuted(
       profile_, it->second.first, it->second.second);
 
   return TRUE;
 }