Add Android stub implementation for AppNotifyChannelUI

chrome/browser/extensions/extension_tab_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_tab_helper.h"
 
 #include "chrome/browser/extensions/crx_installer.h"
+#include "chrome/browser/extensions/app_notify_channel_ui.h"
+#include "chrome/browser/extensions/app_notify_channel_ui_android.h"
+#include "chrome/browser/extensions/app_notify_channel_ui_impl.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/page_action_controller.h"
 #include "chrome/browser/extensions/script_badge_controller.h"
 #include "chrome/browser/extensions/script_executor.h"
 #include "chrome/browser/extensions/webstore_inline_installer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sessions/restore_tab_helper.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
@@ skipping 175 matching lines @@
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_GetAppInstallState,
                         OnGetAppInstallState);
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_Request, OnRequest)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void ExtensionTabHelper::OnDidGetApplicationInfo(
     int32 page_id, const WebApplicationInfo& info) {
-#if !defined(OS_MACOSX)
+  // Android does not implement BrowserWindow.
+#if !defined(OS_MACOSX) && !defined(OS_ANDROID)
   web_app_info_ = info;
 
   NavigationEntry* entry =
       tab_contents_->web_contents()->GetController().GetLastCommittedEntry();
   if (!entry || (entry->GetPageID() != page_id))
     return;
 
   switch (pending_web_app_action_) {
     case CREATE_SHORTCUT: {
       chrome::ShowCreateWebAppShortcutsDialog(
@@ skipping 48 matching lines @@
           requestor_url,
           this));
   installer->BeginInstall();
 }
 
 void ExtensionTabHelper::OnGetAppNotifyChannel(
     const GURL& requestor_url,
     const std::string& client_id,
     int return_route_id,
     int callback_id) {
-
   // Check for permission first.
   Profile* profile =
       Profile::FromBrowserContext(web_contents()->GetBrowserContext());
   ExtensionService* extension_service = profile->GetExtensionService();
   extensions::ProcessMap* process_map = extension_service->process_map();
   content::RenderProcessHost* process =
       tab_contents()->web_contents()->GetRenderProcessHost();
   const Extension* extension =
       extension_service->GetInstalledApp(requestor_url);
 
   std::string error;
   if (!extension ||
       !extension->HasAPIPermission(
         extensions::APIPermission::kAppNotifications) ||
       !process_map->Contains(extension->id(), process->GetID()))
     error = kPermissionError;
 
   // Make sure the extension can cross to the main profile, if called from an
   // an incognito window.
   if (profile->IsOffTheRecord() &&
       !extension_service->CanCrossIncognito(extension))
     error = extension_misc::kAppNotificationsIncognitoError;
 
   if (!error.empty()) {
     Send(new ExtensionMsg_GetAppNotifyChannelResponse(
         return_route_id, "", error, callback_id));
     return;
   }
 
+#if defined(OS_ANDROID)
+  AppNotifyChannelUI* ui = new AppNotifyChannelUIAndroid();

[Jay Civelli, 2012/07/13 20:04:14]

If you added a static Create() method in AppNotifyChannel (implemented in the
impl and android version), then you would not need this.

[nilesh, 2012/07/13 21:25:30]

Done.

+#else
   AppNotifyChannelUI* ui = new AppNotifyChannelUIImpl(
       profile, tab_contents(), extension->name(),
       AppNotifyChannelUI::NOTIFICATION_INFOBAR);
+#endif
 
   scoped_refptr<AppNotifyChannelSetup> channel_setup(
       new AppNotifyChannelSetup(profile,
                                 extension->id(),
                                 client_id,
                                 requestor_url,
                                 return_route_id,
                                 callback_id,
                                 ui,
                                 this->AsWeakPtr()));
@@ skipping 142 matching lines @@
     // last committed entry is not NULL. Last committed entry could be NULL
     // when an interstitial page is injected (e.g. bad https certificate,
     // malware site etc). When this happens, we abort the shortcut update.
     NavigationEntry* entry = controller.GetLastCommittedEntry();
     if (entry)
       GetApplicationInfo(entry->GetPageID());
     else
       pending_web_app_action_ = NONE;
   }
 }