chrome/browser/ui/views/ash/launcher/chrome_launcher_controller_browsertest.cc - Issue 10700130: Introduce LaunchParams struct for opening chrome apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/ash/launcher/chrome_launcher_controller_browsertest.cc

Issue 10700130: Introduce LaunchParams struct for opening chrome apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moar cleanup Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/ash/extension_utils.cc ('K') | « chrome/browser/ui/views/ash/extension_utils.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/ash/launcher/chrome_launcher_controller_browsertest.cc

diff --git a/chrome/browser/ui/views/ash/launcher/chrome_launcher_controller_browsertest.cc b/chrome/browser/ui/views/ash/launcher/chrome_launcher_controller_browsertest.cc

index bd9b2e4137290cd1c984d8feb8b0dadca7aa62e4..31afd6cb7c01693e3019ffb8ccf0ba9769b72a39 100644

--- a/chrome/browser/ui/views/ash/launcher/chrome_launcher_controller_browsertest.cc

+++ b/chrome/browser/ui/views/ash/launcher/chrome_launcher_controller_browsertest.cc

@@ -66,14 +66,8 @@ class LauncherAppBrowserTest : public ExtensionBrowserTest {

service->GetExtensionById(last_loaded_extension_id_, false);

EXPECT_TRUE(extension);

- application_launch::OpenApplication(

- browser()->profile(),

- extension,

- // Overriding manifest to open in a panel.

- container,

- GURL(),

- disposition,

- NULL);

+ application_launch::OpenApplication(application_launch::LaunchParams(

+ browser()->profile(), extension, container, disposition));

return extension;

}