Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4226)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 10700130: Introduce LaunchParams struct for opening chrome apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
index c0fd4d272428803515090a84d750f100f73561f2..9996b6e46d521debe75cbef8e513533663ab8ad9 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
@@ -392,8 +392,9 @@ bool StartupBrowserCreatorImpl::OpenApplicationTab(Profile* profile) {
RecordCmdLineAppHistogram();
- WebContents* app_tab = application_launch::OpenApplicationTab(
- profile, extension, GURL(), NEW_FOREGROUND_TAB);
+ WebContents* app_tab = application_launch::OpenApplication(
+ application_launch::LaunchParams(profile, extension,
+ extension_misc::LAUNCH_TAB, NEW_FOREGROUND_TAB));
return (app_tab != NULL);
}
@@ -427,9 +428,11 @@ bool StartupBrowserCreatorImpl::OpenApplicationWindow(
RecordCmdLineAppHistogram();
+ application_launch::LaunchParams params(profile, extension,
+ launch_container, NEW_WINDOW);
+ params.command_line = &command_line_;
WebContents* tab_in_app_window = application_launch::OpenApplication(
- profile, extension, launch_container, GURL(), NEW_WINDOW,
- &command_line_);
+ params);
if (out_app_contents)
*out_app_contents = tab_in_app_window;

Powered by Google App Engine
This is Rietveld 408576698