Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3516)

Unified Diff: chrome/browser/chromeos/extensions/file_manager_util.cc

Issue 10700130: Introduce LaunchParams struct for opening chrome apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix bad merge Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager_util.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager_util.cc b/chrome/browser/chromeos/extensions/file_manager_util.cc
index f188083ae45501011edb7f95a769f082c9308adc..d01169708b71eb607f0c6eb9685c425c261c3fc5 100644
--- a/chrome/browser/chromeos/extensions/file_manager_util.cc
+++ b/chrome/browser/chromeos/extensions/file_manager_util.cc
@@ -452,8 +452,11 @@ void OpenFileBrowser(const FilePath& path,
return;
content::RecordAction(UserMetricsAction("ShowFileBrowserFullTab"));
- application_launch::OpenApplication(profile, extension,
- extension_misc::LAUNCH_WINDOW, GURL(url), NEW_FOREGROUND_TAB, NULL);
+ application_launch::LaunchParams params(profile, extension,
+ extension_misc::LAUNCH_WINDOW,
+ NEW_FOREGROUND_TAB);
+ params.override_url = GURL(url);
+ application_launch::OpenApplication(params);
}
void ViewRemovableDrive(const FilePath& path) {
@@ -647,9 +650,11 @@ bool ExecuteBuiltinHandler(Browser* browser, const FilePath& path,
if (!extension)
return false;
- application_launch::OpenApplication(
- profile, extension, extension_misc::LAUNCH_WINDOW,
- GetVideoPlayerUrl(url), NEW_FOREGROUND_TAB, NULL);
+ application_launch::LaunchParams params(profile, extension,
+ extension_misc::LAUNCH_WINDOW,
+ NEW_FOREGROUND_TAB);
+ params.override_url = GetVideoPlayerUrl(url);
+ application_launch::OpenApplication(params);
return true;
}
« no previous file with comments | « chrome/browser/background/background_mode_manager.cc ('k') | chrome/browser/extensions/app_notification_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698