Introduce LaunchParams struct for opening chrome apps.

chrome/browser/ui/extensions/application_launch.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_EXTENSIONS_APPLICATION_LAUNCH_H_
 #define CHROME_BROWSER_UI_EXTENSIONS_APPLICATION_LAUNCH_H_
 #pragma once
 
 #include "chrome/common/extensions/extension_constants.h"
 #include "webkit/glue/window_open_disposition.h"
 
 class Browser;
 class CommandLine;
 class GURL;
 class Profile;
 
 namespace content {
 class WebContents;
 }
 
 namespace extensions {
 class Extension;
 }
 
 namespace application_launch {
 
-// Open |extension| in |container|, using |disposition| if container type is
-// TAB. Returns the WebContents* that was created or NULL. If non-empty,
-// |override_url| is used in place of the app launch url. Pass relevant
-// information in |command_line| onto platform app as launch data.
-// |command_line| can be NULL, indicating there is no launch data to pass on.
-// TODO(benwells): Put the parameters to this into an ApplicationLaunchParams
-// struct.
-content::WebContents* OpenApplication(Profile* profile,
-                                      const extensions::Extension* extension,
-                                      extension_misc::LaunchContainer container,
-                                      const GURL& override_url,
-                                      WindowOpenDisposition disposition,
-                                      const CommandLine* command_line);
+struct LaunchParams {
+  LaunchParams(Profile* profile,
+               const extensions::Extension* extension,
+               extension_misc::LaunchContainer container,
+               WindowOpenDisposition disposition);
+
+  // The profile to load the application from.
+  Profile* profile;
+
+  // The extension to load.
+  const extensions::Extension* extension;
+
+  // The container type to launch the application in.
+  extension_misc::LaunchContainer container;
+
+  // If container is TAB, this field controls how the tab is opened.
+  WindowOpenDisposition disposition;
+
+  // If non-empty, use override_url in place of the application's launch url.
+  GURL override_url;
+
+  // If non-NULL, information from the command line may be passed on to the
+  // application.
+  const CommandLine* command_line;
+};
+
+// Open the application in a way specified by |params|.
+content::WebContents* OpenApplication(const LaunchParams& params);
 
 // Opens |url| in a new application panel window for the specified url.
 content::WebContents* OpenApplicationPanel(
     Profile* profile,
     const extensions::Extension* extension,
     const GURL& url);
 
-// Opens a new application window for the specified url. If |as_panel| is true,
-// the application will be opened as a Browser::Type::APP_PANEL in app panel
-// window, otherwise it will be opened as as either Browser::Type::APP a.k.a.
-// "thin frame" (if |extension| is NULL) or Browser::Type::EXTENSION_APP (if
-// |extension| is non-NULL)./ If |app_browser| is not NULL, it is set to the
-// browser that hosts the returned tab.
-content::WebContents* OpenApplicationWindow(
-    Profile* profile,
-    const extensions::Extension* extension,
-    extension_misc::LaunchContainer container,
-    const GURL& url,
-    Browser** app_browser);
-
 // Open |url| in an app shortcut window.  If |update_shortcut| is true,
 // update the name, description, and favicon of the shortcut.
 // There are two kinds of app shortcuts: Shortcuts to a URL,
 // and shortcuts that open an installed application.  This function
 // is used to open the former.  To open the latter, use
-// Browser::OpenApplicationWindow().
+// application_launch::OpenApplication().
 content::WebContents* OpenAppShortcutWindow(Profile* profile,
                                             const GURL& url,
                                             bool update_shortcut);

[Mihai Parparita -not on Chrome, 2012/07/12 04:34:20]

Unless Code Search is lying, the only non-test callsite to OpenApplicationWindow
is
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/ui/startup/...,
and that alway passes in true for update_shortcut. Can that parameter be
removed?

 
-// Open an application for |extension| using |disposition|.  Returns NULL if
-// there are no appropriate existing browser windows for |profile|. If
-// non-empty, |override_url| is used in place of the app launch url.
-content::WebContents* OpenApplicationTab(Profile* profile,
-                                         const extensions::Extension* extension,
-                                         const GURL& override_url,
-                                         WindowOpenDisposition disposition);
-
 }  // namespace application_launch
 
 #endif  // CHROME_BROWSER_UI_EXTENSIONS_APPLICATION_LAUNCH_H_