chrome/browser/ui/webui/chrome_url_data_manager_backend.cc - Issue 10700117: Replaced static URLRequestFileJob factory with non-static protocol handler for File jobs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chrome_url_data_manager_backend.cc

Issue 10700117: Replaced static URLRequestFileJob factory with non-static protocol handler for File jobs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed merge Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/off_the_record_profile_io_data.cc ('K') | « chrome/browser/profiles/profile_impl_io_data.cc ('k') | content/renderer/browser_plugin/browser_plugin_browsertest.cc » ('j') | content/renderer/browser_plugin/browser_plugin_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chrome_url_data_manager_backend.cc

diff --git a/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc b/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc

index 6e6216e7630b789e5cb2806d20eda9595368fed7..815732c9018cacfc240bbd8e2f9fff7d57993f2d 100644

--- a/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc

+++ b/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc

@@ -593,7 +593,8 @@ DevToolsJobFactory::MaybeCreateJob(net::URLRequest* request) const {

if (ShouldLoadFromDisk()) {

FilePath path;

if (IsSupportedURL(request->url(), &path))

- return new net::URLRequestFileJob(request, path);

+ return new net::URLRequestFileJob(

+ request, path, request->context()->network_delegate());

erikwright (departed) 2012/08/15 19:02:03 Perhaps just go ahead and add the network_delegate

shalev 2012/08/15 21:23:41 Done.

}

return new URLRequestChromeJob(request, backend_);