Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: chrome/browser/extensions/extension_resource_protocols.cc

Issue 10700117: Replaced static URLRequestFileJob factory with non-static protocol handler for File jobs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed context from file_dir_job, merged with error_job cl Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_resource_protocols.cc
diff --git a/chrome/browser/extensions/extension_resource_protocols.cc b/chrome/browser/extensions/extension_resource_protocols.cc
index 84907ce45efa7dafbe777dfbc2bf0488eeb2f30c..ecd4b769b0436d42354449f930aadbe195be2ea9 100644
--- a/chrome/browser/extensions/extension_resource_protocols.cc
+++ b/chrome/browser/extensions/extension_resource_protocols.cc
@@ -15,8 +15,9 @@ namespace {
class ExtensionResourcesJob : public net::URLRequestFileJob {
public:
- explicit ExtensionResourcesJob(net::URLRequest* request)
- : net::URLRequestFileJob(request, FilePath()),
+ explicit ExtensionResourcesJob(net::URLRequest* request,
+ net::NetworkDelegate* network_delegate)
+ : net::URLRequestFileJob(request, FilePath(), network_delegate),
thread_id_(content::BrowserThread::UI) {
}
@@ -58,13 +59,18 @@ void ExtensionResourcesJob::ResolvePathDone() {
class ExtensionResourceProtocolHandler
: public net::URLRequestJobFactory::ProtocolHandler {
public:
- ExtensionResourceProtocolHandler() {}
+ explicit ExtensionResourceProtocolHandler(
+ net::NetworkDelegate* network_delegate)
+ : network_delegate_(network_delegate) {
+ }
virtual ~ExtensionResourceProtocolHandler() {}
virtual net::URLRequestJob* MaybeCreateJob(
net::URLRequest* request) const OVERRIDE;
private:
+ net::NetworkDelegate* network_delegate_;
+
DISALLOW_COPY_AND_ASSIGN(ExtensionResourceProtocolHandler);
};
@@ -72,12 +78,12 @@ class ExtensionResourceProtocolHandler
net::URLRequestJob*
ExtensionResourceProtocolHandler::MaybeCreateJob(
net::URLRequest* request) const {
- return new ExtensionResourcesJob(request);
+ return new ExtensionResourcesJob(request, network_delegate_);
}
} // namespace
net::URLRequestJobFactory::ProtocolHandler*
-CreateExtensionResourceProtocolHandler() {
- return new ExtensionResourceProtocolHandler();
+CreateExtensionResourceProtocolHandler(net::NetworkDelegate* network_delegate) {
+ return new ExtensionResourceProtocolHandler(network_delegate);
}

Powered by Google App Engine
This is Rietveld 408576698