Replaced static URLRequestFileJob factory with non-static protocol handler for File jobs

content/renderer/browser_plugin/browser_plugin_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/browser_plugin_browsertest.h"
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "content/common/browser_plugin_messages.h"
@@ skipping 69 matching lines @@
   ASSERT_TRUE(msg);
   PickleIterator iter = IPC::SyncMessage::GetDataIterator(msg);
   BrowserPluginHostMsg_ResizeGuest::SendParam  resize_params;
   ASSERT_TRUE(IPC::ReadParam(msg, &iter, &resize_params));
   int instance_id = resize_params.a;
   BrowserPluginHostMsg_ResizeGuest_Params params(resize_params.b);
   EXPECT_EQ(640, params.width);
   EXPECT_EQ(480, params.height);
   // Verify that the browser plugin wasn't already waiting on a resize when this
   // resize happened.
-  EXPECT_FALSE(params.resize_pending);
+  EXPECT_EQ(false, params.resize_pending);

[mmenke, 2012/08/15 14:57:16]

Why this change?  Doesn't seem to belong in this CL.  Also, the old code is the
preferred form for testing bools.

[shalev, 2012/08/15 21:23:41]

Oops, this change is not supposed to be here (it was only there temporarily
because I was investigating why
EXPECT_EQ(false, __)
seems to not build on my machine).

 
   MockBrowserPlugin* browser_plugin =
       static_cast<MockBrowserPlugin*>(
           browser_plugin_manager()->GetBrowserPlugin(instance_id));
   ASSERT_TRUE(browser_plugin);
   // Now the browser plugin is expecting a UpdateRect resize.
   EXPECT_TRUE(browser_plugin->resize_pending_);
 
   // Send the BrowserPlugin an UpdateRect equal to its container size.
   // That should clear the resize_pending_ flag.
@@ skipping 212 matching lines @@
   EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString("url"));
 
   ExecuteJavaScript(kRemoveEventListener);
   browser_plugin->DidNavigate(GURL(kGoogleNewsURL));
   // The URL variable should not change because we've removed the event
   // listener.
   EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString("url"));
 }
 
 }  // namespace content