Break Crankshaft into phases.

src/lithium.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 604 matching lines @@
   void SkipUninteresting() {
     while (current_iterator_.env() != NULL && current_iterator_.Done()) {
       current_iterator_ = ShallowIterator(current_iterator_.env()->outer());
     }
   }
 
   ShallowIterator current_iterator_;
 };
 
 
+class LChunk;
 class LGap;
 class LLabel;
 
 // Superclass providing data and behavior common to all the
 // arch-specific LChunk classes.
 class LChunkBase: public ZoneObject {
  public:
   LChunkBase(CompilationInfo* info, HGraph* graph)
     : spill_slot_count_(0),
       info_(info),
       graph_(graph),
       instructions_(32, graph->zone()),
       pointer_maps_(8, graph->zone()),
       inlined_closures_(1, graph->zone()) { }
 
+  static LChunk* NewChunk(HGraph* graph);
+
   void AddInstruction(LInstruction* instruction, HBasicBlock* block);
   LConstantOperand* DefineConstantOperand(HConstant* constant);
   HConstant* LookupConstant(LConstantOperand* operand) const;
   Representation LookupLiteralRepresentation(LConstantOperand* operand) const;
 
   int ParameterAt(int index);
   int GetParameterStackSlot(int index) const;
   int spill_slot_count() const { return spill_slot_count_; }
   CompilationInfo* info() const { return info_; }
   HGraph* graph() const { return graph_; }
@@ skipping 13 matching lines @@
   }
 
   void AddInlinedClosure(Handle<JSFunction> closure) {
     inlined_closures_.Add(closure, zone());
   }
 
   Zone* zone() const { return info_->zone(); }
 
  protected:
   int spill_slot_count_;
+  static Handle<Code> Codegen(LChunk* chunk);

[danno, 2012/07/12 08:38:03]

Why do you need to make this static? If you make it an instance method, you
don't need the wrapper methods that call through in the subclasses.

[sanjoy, 2012/07/12 09:06:49]

As I mentioned, LCodeGen specifically needs an LChunk.

 
  private:
   CompilationInfo* info_;
   HGraph* const graph_;
   ZoneList<LInstruction*> instructions_;
   ZoneList<LPointerMap*> pointer_maps_;
   ZoneList<Handle<JSFunction> > inlined_closures_;
 };
 
 
 int ElementsKindToShiftSize(ElementsKind elements_kind);
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_LITHIUM_H_