chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 10700071: browser: Remove fullscreen functions and have callers call FullscreenController directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 10700071: browser: Remove fullscreen functions and have callers call FullscreenController directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more includes Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index a4e41aff256f0ee141597487df250d4a63042084..e007577a2979aca497e4d77434ca0656cbc36ad4 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -37,6 +37,7 @@

#import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"

#import "chrome/browser/ui/cocoa/web_dialog_window_controller.h"

#import "chrome/browser/ui/cocoa/website_settings_bubble_controller.h"

+#include "chrome/browser/ui/fullscreen/fullscreen_controller.h"

#include "chrome/browser/ui/page_info_bubble.h"

#include "chrome/browser/ui/tab_contents/tab_contents.h"

#include "chrome/common/chrome_notification_types.h"

@@ -125,7 +126,7 @@ void BrowserWindowCocoa::Show() {

[window() orderOut:controller_];

[window() miniaturize:controller_];

} else if (initial_show_state_ == ui::SHOW_STATE_FULLSCREEN) {

- browser_->ToggleFullscreenMode();

+ browser_->fullscreen_controller()->ToggleFullscreenMode();

Ben Goodger (Google) 2012/07/03 19:51:35 Since this seems the most common use case, can we

tfarina 2012/07/03 22:38:38 Yup. Done.

}

initial_show_state_ = ui::SHOW_STATE_DEFAULT;

« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »