chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc - Issue 10700007: Page actions behave as disableable browser actions when script badges are enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

Issue 10700007: Page actions behave as disableable browser actions when script badges are enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/browser_action_view.cc ('K') | « chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

diff --git a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

index 826c117e7013d5a6ee7cff693c9fc4f6792fda49..e26037be9efe992e56c133b6dfd9e6155411b75d 100644

--- a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

+++ b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

@@ -87,6 +87,11 @@ void BrowserActionOverflowMenuController::CancelMenu() {

menu_->Cancel();

}

+bool BrowserActionOverflowMenuController::IsCommandEnabled(int id) const {

+ BrowserActionView* view = (*views_)[start_index_ + id - 1];

+ return view->button()->IsEnabled(owner_->GetCurrentTabId());

void BrowserActionOverflowMenuController::ExecuteCommand(int id) {

BrowserActionView* view = (*views_)[start_index_ + id - 1];

owner_->OnBrowserActionExecuted(view->button());