Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: chrome/common/extensions/extension.cc

Issue 10700007: Page actions behave as disableable browser actions when script badges are enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: estade + sky Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 462ce13779bf774696cf931537d61ee035c96cb9..d6033d5f487f8b21c342c28640e08ec65421569d 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -805,9 +805,10 @@ scoped_ptr<ExtensionAction> Extension::LoadExtensionActionHelper(
string16* error) {
scoped_ptr<ExtensionAction> result(new ExtensionAction(id(), action_type));
- // Page actions are hidden by default, and browser actions ignore
- // visibility.
- result->SetIsVisible(ExtensionAction::kDefaultTabId, false);
+ // Page actions are hidden/disabled by default, and browser actions are
+ // visible/enabled by default.
+ result->SetIsVisible(ExtensionAction::kDefaultTabId,
+ action_type != ExtensionAction::TYPE_PAGE);
if (manifest_version_ == 1) {
ListValue* icons = NULL;
« no previous file with comments | « chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698