Issue 10700: Fix assignment of a javascript: URL to window.location.href...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10700: Fix assignment of a javascript: URL to window.location.href... (Closed)

Created:
12 years, 1 month ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
Feng Qian

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix assignment of a javascript: URL to window.location.href Covered by LayoutTests/fast/loader/javascript-url-encoding-2.html, which times out without this fix. My fix is to just replicate what is done in JSLocationCustom.cpp. R=fqian Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5380

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -17 lines)			Patch
	M	webkit/port/page/Location.cpp	View		4 chunks	+8 lines, -16 lines	0 comments	Download
	M	webkit/tools/layout_tests/test_lists/win/tests_fixable.txt	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Feng Qian

12 years, 1 month ago (2008-11-13 21:14:07 UTC) #2

lgtm,

I remember parseURL had very subtle difference (compat) from KURL protocolIs,
and we believed KURL::protocolIs is the right way to go.



On 2008/11/13 21:06:07, darin wrote:
>

Expand Messages | Collapse Messages