chromeos: Fix pixelated icons in app list and launcher (part 1)

ui/gfx/image/image_skia_sources.h

Index: ui/gfx/image/image_skia_sources.h
diff --git a/ui/gfx/image/image_skia_sources.h b/ui/gfx/image/image_skia_sources.h
new file mode 100644
index 0000000000000000000000000000000000000000..3803cc44d675e9ffae91a8dae04ce03a45a17101
--- /dev/null
+++ b/ui/gfx/image/image_skia_sources.h
@@ -0,0 +1,33 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_GFX_IMAGE_IMAGE_SKIA_SOURCES_H_
+#define UI_GFX_IMAGE_IMAGE_SKIA_SOURCES_H_
+#pragma once
+
+#include "ui/base/ui_export.h"
+#include "ui/gfx/shadow_value.h"
+
+namespace gfx {
+
+class ImageSkia;
+class ImageSkiaSource;
+class Size;
+
+namespace image_skia_sources {

[oshima, 2012/07/03 23:00:06]

I wonder if we can use the same format as
SkBitmapOperations (no namespace, and all static methods).

[xiyuan, 2012/07/10 20:02:13]

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Nonmem...

"Rather than creating classes only to group static member functions which do not
share static data, use namespaces instead."

+
+// Creates an ImageSkiaSource that resizes |source| to given |target_dip_size|.
+// Callers of the function takes ownership of returned ImageSkiaSource.
+UI_EXPORT ImageSkiaSource* CreateResizeSource(const ImageSkia& source,
+                                              const Size& target_dip_size);
+
+// Creates an ImageSkiaSource that generates drop shadow for |source|.
+// Callers of the function takes ownership of returned ImageSkiaSource.
+UI_EXPORT ImageSkiaSource* CreateDropShadowSource(const ImageSkia& source,
+                                                  const ShadowValues& shadows);
+

[oshima, 2012/07/03 23:00:06]

Do you think these fill be useful in outside of ash?
Just trying to make sure we're putting them in the right place.

[pkotwicz, 2012/07/04 00:19:50]

I think views code which is outside ash can potentially benefit

[xiyuan, 2012/07/10 20:02:13]

And app list is no longer part of ash. It lives as a UI component now. So we
need these out of ash.

+}  // namespace image_skia_sources
+}  // namespace gfx
+
+#endif  // UI_GFX_IMAGE_IMAGE_SKIA_SOURCES_H_