chromeos: Fix pixelated icons in app list and launcher (part 1)

chrome/browser/extensions/image_loading_tracker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/image_loading_tracker.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
+#include "chrome/common/extensions/extension_icon_set.h"
 #include "chrome/common/extensions/extension_resource.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "grit/component_extension_resources_map.h"
 #include "grit/theme_resources.h"
 #include "skia/ext/image_operations.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/image/image.h"
-#include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/image/image_skia_rep.h"
+#include "ui/gfx/screen.h"
 #include "webkit/glue/image_decoder.h"
 
 using content::BrowserThread;
 using extensions::Extension;
 
 ////////////////////////////////////////////////////////////////////////////////
 // ImageLoadingTracker::Observer
 
 ImageLoadingTracker::Observer::~Observer() {}
 
 ////////////////////////////////////////////////////////////////////////////////
 // ImageLoadingTracker::ImageInfo
 
 ImageLoadingTracker::ImageInfo::ImageInfo(
-    const ExtensionResource& resource, gfx::Size max_size)
-    : resource(resource), max_size(max_size) {
+    const ExtensionResource& resource,
+    const gfx::Size& max_size,
+    ui::ScaleFactor scale_factor)
+    : resource(resource),
+      max_size(max_size),
+      scale_factor(scale_factor) {
 }
 
 ImageLoadingTracker::ImageInfo::~ImageInfo() {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // ImageLoadingTracker::PendingLoadInfo
 
 ImageLoadingTracker::PendingLoadInfo::PendingLoadInfo()
   : extension(NULL),
@@ skipping 17 matching lines @@
     DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::FILE));
   }
 
   // Lets this class know that the tracker is no longer interested in the
   // results.
   void StopTracking() {
     tracker_ = NULL;
   }
 
   // Instructs the loader to load a task on the File thread.
-  void LoadImage(const ExtensionResource& resource,
-                 const gfx::Size& max_size,
-                 int id) {
+  void LoadImage(const ImageInfo& image_info, int id) {
     DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::FILE));
     BrowserThread::PostTask(
         BrowserThread::FILE, FROM_HERE,
-        base::Bind(&ImageLoader::LoadOnFileThread, this, resource,
-                   max_size, id));
+        base::Bind(&ImageLoader::LoadOnFileThread, this, image_info, id));
   }
 
-  void LoadOnFileThread(const ExtensionResource& resource,
-                        const gfx::Size& max_size,
-                        int id) {
+  void LoadOnFileThread(const ImageInfo& image_info, int id) {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
     // Read the file from disk.
     std::string file_contents;
-    FilePath path = resource.GetFilePath();
+    FilePath path = image_info.resource.GetFilePath();
     if (path.empty() || !file_util::ReadFileToString(path, &file_contents)) {
-      ReportBack(NULL, resource, gfx::Size(), id);
+      ReportBack(NULL, image_info, gfx::Size(), id);
       return;
     }
 
     // Decode the image using WebKit's image decoder.
     const unsigned char* data =
         reinterpret_cast<const unsigned char*>(file_contents.data());
     webkit_glue::ImageDecoder decoder;
     scoped_ptr<SkBitmap> decoded(new SkBitmap());
     // Note: This class only decodes images from extension resources. Chrome
     // doesn't (for security reasons) directly load extension resources provided
     // by the extension author, but instead decodes them in a separate
     // locked-down utility process. Only if the decoding succeeds is the image
     // saved from memory to disk and subsequently used in the Chrome UI.
     // Chrome is therefore decoding images here that were generated by Chrome.
     *decoded = decoder.Decode(data, file_contents.length());
     if (decoded->empty()) {
-      ReportBack(NULL, resource, gfx::Size(), id);
+      ReportBack(NULL, image_info, gfx::Size(), id);
       return;  // Unable to decode.
     }
 
     gfx::Size original_size(decoded->width(), decoded->height());
 
-    if (decoded->width() > max_size.width() ||
-        decoded->height() > max_size.height()) {
+    if (decoded->width() > image_info.max_size.width() ||
+        decoded->height() > image_info.max_size.height()) {
       // The bitmap is too big, re-sample.
       *decoded = skia::ImageOperations::Resize(
           *decoded, skia::ImageOperations::RESIZE_LANCZOS3,
-          max_size.width(), max_size.height());
+          image_info.max_size.width(), image_info.max_size.height());
     }
 
-    ReportBack(decoded.release(), resource, original_size, id);
+    ReportBack(decoded.release(), image_info, original_size, id);
   }
 
   // Instructs the loader to load a resource on the File thread.
-  void LoadResource(const ExtensionResource& resource,
-                    const gfx::Size& max_size,
-                    int id,
-                    int resource_id) {
+  void LoadResource(const ImageInfo& image_info, int id, int resource_id) {
     DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::FILE));
     BrowserThread::PostTask(
         BrowserThread::FILE, FROM_HERE,
-        base::Bind(&ImageLoader::LoadResourceOnFileThread, this, resource,
-                   max_size, id, resource_id));
+        base::Bind(&ImageLoader::LoadResourceOnFileThread, this, image_info,
+                   id, resource_id));
   }
 
-  void LoadResourceOnFileThread(const ExtensionResource& resource,
-                                const gfx::Size& max_size,
+  void LoadResourceOnFileThread(const ImageInfo& image_info,
                                 int id,
                                 int resource_id) {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
     SkBitmap* image = ExtensionIconSource::LoadImageByResourceId(
         resource_id);
-    ReportBack(image, resource, max_size, id);
+    ReportBack(image, image_info, image_info.max_size, id);
   }
 
-  void ReportBack(SkBitmap* image, const ExtensionResource& resource,
+  void ReportBack(SkBitmap* image, const ImageInfo& image_info,
                   const gfx::Size& original_size, int id) {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
     BrowserThread::PostTask(
         callback_thread_id_, FROM_HERE,
         base::Bind(&ImageLoader::ReportOnUIThread, this,
-                   image, resource, original_size, id));
+                   image, image_info, original_size, id));
   }
 
-  void ReportOnUIThread(SkBitmap* image, const ExtensionResource& resource,
+  void ReportOnUIThread(SkBitmap* image, const ImageInfo& image_info,
                         const gfx::Size& original_size, int id) {
     DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
     if (tracker_)
-      tracker_->OnImageLoaded(image, resource, original_size, id, true);
+      tracker_->OnImageLoaded(image, image_info, original_size, id, true);
 
     delete image;
   }
 
  private:
   friend class base::RefCountedThreadSafe<ImageLoader>;
   ~ImageLoader() {}
 
   // The tracker we are loading the image for. If NULL, it means the tracker is
   // no longer interested in the reply.
@@ skipping 20 matching lines @@
   // any valid image load tasks have been posted.
   if (loader_)
     loader_->StopTracking();
 }
 
 void ImageLoadingTracker::LoadImage(const Extension* extension,
                                     const ExtensionResource& resource,
                                     const gfx::Size& max_size,
                                     CacheParam cache) {
   std::vector<ImageInfo> info_list;
-  info_list.push_back(ImageInfo(resource, max_size));
+  info_list.push_back(ImageInfo(resource, max_size, ui::SCALE_FACTOR_NONE));
   LoadImages(extension, info_list, cache);
 }
 
+void ImageLoadingTracker::LoadDIPImage(
+    const extensions::Extension* extension,
+    int preferred_dip_size,
+    gfx::Size max_dip_size,
+    CacheParam cache) {
+  if (!gfx::Screen::IsDIPEnabled()) {
+    LoadImage(extension,
+              extension->GetIconResource(preferred_dip_size,
+                                         ExtensionIconSet::MATCH_BIGGER),
+              max_dip_size,
+              cache);
+    return;

[oshima, 2012/07/10 23:51:06]

is there an issue using ui::SCALE_FACTOR_100P when DIP isn't enabled?

[xiyuan, 2012/07/11 17:39:13]

I assumed ui::SCALE_FACTOR_100P is the default when DIP is not enabled. Is that
not the case?

Anyway, I'll revert the ImageLoadingTracker change in this CL. Let's move
relevant discussion to http://codereview.chromium.org/10701087/. 

[oshima, 2012/07/11 18:08:41]

I probably wasn't clear enough. I was asking if the following is enough.

ui::ScaleFactor scale_factor =
  gfx::Screen::IsDIPEnabled() ? ui::SCALE_FACTOR_200P : ui::SCALE_FACTOR_100P;

below. 

[xiyuan, 2012/07/11 21:40:40]

I see your point. Let's follow ImageLoadingTracker change in
http://codereview.chromium.org/10701087/

Peter also mentioned that we probably should have a way to provide image for all
scale factors.

+  }
+
+  // Always use a hi-res resource when DIP is enabled so that it is safe to
+  // complete hand off the image to the caller.
+  const ui::ScaleFactor scale_factor = ui::SCALE_FACTOR_200P;
+  const float scale = ui::GetScaleFactorScale(scale_factor);
+  std::vector<ImageInfo> info_list;
+  info_list.push_back(ImageInfo(
+      extension->GetIconResource(static_cast<int>(preferred_dip_size * scale),
+                                 ExtensionIconSet::MATCH_BIGGER),
+      max_dip_size.Scale(scale),
+      scale_factor));
+  LoadImages(extension, info_list, cache);
+}
+
+void ImageLoadingTracker::LoadDIPImage(
+    const extensions::Extension* extension,
+    int preferred_dip_size,
+    gfx::Size max_dip_size,
+    CacheParam cache) {
+  if (!gfx::Screen::IsDIPEnabled()) {
+    LoadImage(extension,
+              extension->GetIconResource(preferred_dip_size,
+                                         ExtensionIconSet::MATCH_BIGGER),
+              max_dip_size,
+              cache);
+    return;
+  }
+
+  float scale = ui::GetScaleFactorScale(ui::SCALE_FACTOR_200P);
+  std::vector<ImageInfo> info_list;
+  info_list.push_back(ImageInfo(
+      extension->GetIconResource(static_cast<int>(preferred_dip_size * scale),
+                                 ExtensionIconSet::MATCH_BIGGER),
+      gfx::Size(static_cast<int>(max_dip_size.width() * scale),
+                static_cast<int>(max_dip_size.height() * scale)),

[oshima, 2012/07/10 23:51:06]

max_dip_size.Scale(scale)

[xiyuan, 2012/07/11 17:39:13]

Bad merge as I already have a LoadDIPImage just above. :p

+      scale));
+  LoadImages(extension, info_list, cache);
+}
+
 void ImageLoadingTracker::LoadImages(const Extension* extension,
                                      const std::vector<ImageInfo>& info_list,
                                      CacheParam cache) {
   PendingLoadInfo load_info;
   load_info.extension = extension;
   load_info.cache = cache;
   load_info.extension_id = extension->id();
   load_info.pending_count = info_list.size();
   int id = next_id_++;
   load_map_[id] = load_info;
 
   for (std::vector<ImageInfo>::const_iterator it = info_list.begin();
        it != info_list.end(); ++it) {
     // Load resources for special component extensions.
     if (load_info.extension_id == extension_misc::kWebStoreAppId) {
       if (!loader_)
         loader_ = new ImageLoader(this);
-      loader_->LoadResource(it->resource, it->max_size, id, IDR_WEBSTORE_ICON);
+      loader_->LoadResource(*it, id, IDR_WEBSTORE_ICON);
       continue;
     } else if (load_info.extension_id == extension_misc::kChromeAppId) {
       if (!loader_)
         loader_ = new ImageLoader(this);
-      loader_->LoadResource(it->resource,
-                            it->max_size,
-                            id,
-                            IDR_PRODUCT_LOGO_128);
+      loader_->LoadResource(*it, id, IDR_PRODUCT_LOGO_128);
       continue;
     }
 
     // If we don't have a path we don't need to do any further work, just
     // respond back.
     if (it->resource.relative_path().empty()) {
-      OnImageLoaded(NULL, it->resource, it->max_size, id, false);
+      OnImageLoaded(NULL, *it, it->max_size, id, false);
       continue;
     }
 
     DCHECK(extension->path() == it->resource.extension_root());
 
     // See if the extension has the image already.
     if (extension->HasCachedImage(it->resource, it->max_size)) {
       SkBitmap image = extension->GetCachedImage(it->resource, it->max_size);
-      OnImageLoaded(&image, it->resource, it->max_size, id, false);
+      OnImageLoaded(&image, *it, it->max_size, id, false);
       continue;
     }
 
     // Instruct the ImageLoader to load this on the File thread. LoadImage and
     // LoadResource do not block.
     if (!loader_)
       loader_ = new ImageLoader(this);
 
     int resource_id;
     if (IsComponentExtensionResource(extension, it->resource, resource_id))
-      loader_->LoadResource(it->resource, it->max_size, id, resource_id);
+      loader_->LoadResource(*it, id, resource_id);
     else
-      loader_->LoadImage(it->resource, it->max_size, id);
+      loader_->LoadImage(*it, id);
   }
 }
 
 bool ImageLoadingTracker::IsComponentExtensionResource(
     const Extension* extension,
     const ExtensionResource& resource,
     int& resource_id) const {
   if (extension->location() != Extension::COMPONENT)
     return false;
 
   FilePath directory_path = extension->path();
   FilePath relative_path = directory_path.BaseName().Append(
       resource.relative_path());
 
   for (size_t i = 0; i < kComponentExtensionResourcesSize; ++i) {
     FilePath resource_path =
         FilePath().AppendASCII(kComponentExtensionResources[i].name);
     resource_path = resource_path.NormalizePathSeparators();
 
     if (relative_path == resource_path) {
       resource_id = kComponentExtensionResources[i].value;
       return true;
     }
   }
   return false;
 }
 
 void ImageLoadingTracker::OnImageLoaded(
     SkBitmap* image,
-    const ExtensionResource& resource,
+    const ImageInfo& image_info,
     const gfx::Size& original_size,
     int id,
     bool should_cache) {
   LoadMap::iterator load_map_it = load_map_.find(id);
   DCHECK(load_map_it != load_map_.end());
   PendingLoadInfo* info = &load_map_it->second;
 
   // Save the pending results.
   DCHECK(info->pending_count > 0);
   info->pending_count--;
-  if (image)
-    info->bitmaps.push_back(*image);
+  if (image) {
+    info->images.AddRepresentation(gfx::ImageSkiaRep(*image,
+        image_info.scale_factor));
+  }
 
   // Add to the extension's image cache if requested.
   DCHECK(info->cache != CACHE || info->extension);
   if (should_cache && info->cache == CACHE  &&
-      !info->extension->HasCachedImage(resource, original_size)) {
-    info->extension->SetCachedImage(resource, image ? *image : SkBitmap(),
+      !info->extension->HasCachedImage(image_info.resource, original_size)) {
+    info->extension->SetCachedImage(image_info.resource,
+                                    image ? *image : SkBitmap(),
                                     original_size);
   }
 
   // If all pending images are done then report back.
   if (info->pending_count == 0) {
-    gfx::Image image;
+    gfx::Image image(info->images);
     std::string extension_id = info->extension_id;
 
-    if (info->bitmaps.size() > 0) {
-      gfx::ImageSkia image_skia;
-      for (std::vector<SkBitmap>::const_iterator it = info->bitmaps.begin();
-           it != info->bitmaps.end(); ++it) {
-        // TODO(pkotwicz): Do something better but ONLY when DIP is enabled.
-        image_skia.AddRepresentation(
-            gfx::ImageSkiaRep(*it, ui::SCALE_FACTOR_100P));
-      }
-      image = gfx::Image(image_skia);
-    }
-
     load_map_.erase(load_map_it);
 
     // ImageLoadingTracker might be deleted after the callback so don't
     // anything after this statement.
     observer_->OnImageLoaded(image, extension_id, id);
   }
 }
 
 void ImageLoadingTracker::Observe(int type,
                                   const content::NotificationSource& source,
                                   const content::NotificationDetails& details) {
   DCHECK(type == chrome::NOTIFICATION_EXTENSION_UNLOADED);
 
   const Extension* extension =
       content::Details<extensions::UnloadedExtensionInfo>(details)->extension;
 
   // Remove reference to this extension from all pending load entries. This
   // ensures we don't attempt to cache the image when the load completes.
   for (LoadMap::iterator i = load_map_.begin(); i != load_map_.end(); ++i) {
     PendingLoadInfo* info = &i->second;
     if (info->extension == extension) {
       info->extension = NULL;
       info->cache = DONT_CACHE;
     }
   }
 }