Move application creation and extension install prompt showing off Browser and onto ExtensionTabHel…

chrome/browser/automation/testing_automation_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/testing_automation_provider.h"
 
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 4000 matching lines @@
         manager,
         service,
         this,
         reply_message);
 
     FilePath extension_path(path_string);
     // If the given path has a 'crx' extension, assume it is a packed extension
     // and install it. Otherwise load it as an unpacked extension.
     if (extension_path.MatchesExtension(FILE_PATH_LITERAL(".crx"))) {
       ExtensionInstallPrompt* client =
-          (with_ui ? new ExtensionInstallPrompt(browser) : NULL);
+          (with_ui ? chrome::CreateExtensionInstallPromptWithBrowser(

[Aaron Boodman, 2012/07/03 00:52:14]

I'm no style expert, but this looks weird.

[Ben Goodger (Google), 2012/07/03 19:17:00]

Done.

+              browser) : NULL);
       scoped_refptr<CrxInstaller> installer(
           CrxInstaller::Create(service, client));
       if (!with_ui)
         installer->set_allow_silent_install(true);
       installer->set_install_cause(extension_misc::INSTALL_CAUSE_AUTOMATION);
       if (from_webstore)
         installer->set_creation_flags(Extension::FROM_WEBSTORE);
       installer->InstallCrx(extension_path);
     } else {
       scoped_refptr<extensions::UnpackedInstaller> installer(
@@ skipping 2701 matching lines @@
 void TestingAutomationProvider::OnRemoveProvider() {
   if (g_browser_process)
     g_browser_process->GetAutomationProviderList()->RemoveProvider(this);
 }
 
 void TestingAutomationProvider::EnsureTabSelected(Browser* browser,
                                                   WebContents* tab) {
   if (chrome::GetActiveWebContents(browser) != tab)
     chrome::ActivateTabAt(browser, chrome::GetIndexOfTab(browser, tab), true);
 }