webkit/plugins/ppapi/ppapi_plugin_instance.cc - Issue 10699045: Fix PPB_MouseLock.LockMouse crash and add tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.cc

Issue 10699045: Fix PPB_MouseLock.LockMouse crash and add tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: change in response to Dave's suggestions. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/ppapi/ppapi_plugin_instance.cc

diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.cc b/webkit/plugins/ppapi/ppapi_plugin_instance.cc

index 6ebf2a28bf8bf603a0b9add9227a937ae9c9596f..898365db4b7add315c8b8566840839419c5228a4 100644

--- a/webkit/plugins/ppapi/ppapi_plugin_instance.cc

+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.cc

@@ -1602,7 +1602,7 @@ bool PluginInstance::IsProcessingUserGesture() {

}

void PluginInstance::OnLockMouseACK(bool succeeded) {

- if (TrackedCallback::IsPending(lock_mouse_callback_)) {

+ if (!TrackedCallback::IsPending(lock_mouse_callback_)) {

NOTREACHED();

return;

}

« ppapi/tests/test_mouse_lock.h ('K') | « ppapi/thunk/enter.cc ('k') | no next file » | no next file with comments »