Add presubmit script to verify that scaled resources are correct dimensions.

chrome/app/theme/PRESUBMIT.py

+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Presubmit script for Chromium theme resources.
+
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
+for more details about the presubmit API built into gcl/git cl, and see
+http://www.chromium.org/developers/web-development-style-guide for the rules
+we're checking against here.
+"""
+
+

[oshima_google, 2012/07/16 19:23:20]

keep 1 new lines. same for other places.

[flackr, 2012/07/19 20:24:50]

Just following the style guide. Not sure if that means two blank lines after the
top-level comment or not, but the rest should be correct.

http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Blank_...

+def CheckChangeOnUpload(input_api, output_api):
+  return _CommonChecks(input_api, output_api)
+
+
+def CheckChangeOnCommit(input_api, output_api):
+  return _CommonChecks(input_api, output_api)
+
+
+def _CommonChecks(input_api, output_api):
+  """Checks common to both upload and commit."""
+  results = []
+  resources = input_api.os_path.join(input_api.PresubmitLocalPath(),
+      '../../../ui/resources')
+
+  # List of paths with their associated scale factor. This is used to verify
+  # that the images modified in one are the correct scale of the other.
+  path_scales = [
+    [[1, 'default_100_percent/'], [2, 'default_200_percent/']],
+    [[1, 'touch_100_percent/'], [2, 'touch_200_percent/']],
+  ]

[oshima_google, 2012/07/16 19:23:20]

This must be same for all resources directory, so isn't it better to put this in
the common place?

[oshima, 2012/07/17 20:20:49]

I guess this can be different for webui?

[flackr, 2012/07/19 20:24:50]

If you think this makes more sense, I thought with the fact that these
directories are defined separately by the resource grd files that it made sense
to define them separately for the presubmit scripts too.

+
+  import sys
+  old_path = sys.path
+
+  try:
+    sys.path = [resources] + old_path
+    from resource_check import resource_scale_factors
+
+    for paths in path_scales:
+      results.extend(resource_scale_factors.ResourceScaleFactors(
+          input_api, output_api, paths).RunChecks())
+  finally:
+    sys.path = old_path
+
+  return results