Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3243)

Unified Diff: chrome/browser/ui/webui/signin/login_ui_service.h

Issue 10699013: Add a method to LoginUIService to open the sign in UI in a popup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/login_ui_service.h
===================================================================
--- chrome/browser/ui/webui/signin/login_ui_service.h (revision 144917)
+++ chrome/browser/ui/webui/signin/login_ui_service.h (working copy)
@@ -39,10 +39,12 @@
// Sets the currently active login UI. It is illegal to call this if there is
// already login UI visible.
+ // Fires chrome::NOTIFICATION_LOGIN_UI_CHANGED.
void SetLoginUI(LoginUI* ui);
// Called when login UI is closed. If the passed UI is the current login UI,
// sets current_login_ui() to null.
+ // Fires chrome::NOTIFICATION_LOGIN_UI_CHANGED.
void LoginUIClosed(LoginUI* ui);
// Brings the login UI to the foreground, or if there is no login UI,
@@ -50,7 +52,15 @@
// Virtual for mocking purposes.
virtual void ShowLoginUI(Browser* browser);
+ // Same as ShowLoginUI but opens a popup with the login UI instead of a
+ // new tab.
+ // Note that if an existing login UI is already open, this method will focus
+ // that UI even though it is not a popup.
+ virtual void ShowLoginDialogUI(Browser* browser);
+
private:
+ void FireLoginUIChanged() const;
+
// Weak pointer to the currently active login UI, or null if none.
LoginUI* ui_;
« no previous file with comments | « no previous file | chrome/browser/ui/webui/signin/login_ui_service.cc » ('j') | chrome/browser/ui/webui/signin/login_ui_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698