Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Unified Diff: chrome/browser/ui/webui/signin/login_ui_service.cc

Issue 10699013: Add a method to LoginUIService to open the sign in UI in a popup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/login_ui_service.cc
===================================================================
--- chrome/browser/ui/webui/signin/login_ui_service.cc (revision 145382)
+++ chrome/browser/ui/webui/signin/login_ui_service.cc (working copy)
@@ -13,14 +13,28 @@
LoginUIService::~LoginUIService() {}
+void LoginUIService::AddObserver(Observer* o) {
+ if (o)
jam 2012/07/10 16:13:07 why do you need to handle someone calling add/remo
Munjal (Google) 2012/07/10 16:46:15 Done.
+ observer_list_.AddObserver(o);
+}
+
+void LoginUIService::RemoveObserver(Observer* o) {
+ if (o)
+ observer_list_.RemoveObserver(o);
+}
+
void LoginUIService::SetLoginUI(LoginUI* ui) {
DCHECK(!current_login_ui() || current_login_ui() == ui);
ui_ = ui;
+ FOR_EACH_OBSERVER(Observer, observer_list_, OnLoginUIShown(ui_));
}
void LoginUIService::LoginUIClosed(LoginUI* ui) {
- if (current_login_ui() == ui)
- ui_ = NULL;
+ if (current_login_ui() != ui)
+ return;
+
+ FOR_EACH_OBSERVER(Observer, observer_list_, OnLoginUIClosed(ui_));
+ ui_ = NULL;
}
void LoginUIService::ShowLoginUI(Browser* browser) {

Powered by Google App Engine
This is Rietveld 408576698