Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 10699006: Add test for native extensions that copies the extension to a test directory and runs it. (Closed)

Created:
8 years, 5 months ago by Bill Hesse
Modified:
8 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add test for native extensions that copies the extension to a test directory and runs it. BUG=dart:1817 TEST=standalone/io/test_extension_test Committed: https://code.google.com/p/dart/source/detail?r=9247

Patch Set 1 #

Patch Set 2 : Add MacOS platform. #

Patch Set 3 : Add Windows platform. #

Patch Set 4 : Add Windows platform. #

Patch Set 5 : Fix bug #

Patch Set 6 : Fix comment and long line in multitest.dart #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -15 lines) Patch
M tests/standalone/io/test_extension_test.dart View 1 2 3 4 5 1 chunk +69 lines, -8 lines 3 comments Download
A + tests/standalone/io/test_extension_tester.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 4 5 3 chunks +0 lines, -5 lines 0 comments Download
M tools/testing/dart/multitest.dart View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
8 years, 5 months ago (2012-06-28 13:50:12 UTC) #1
Søren Gjesse
lgtm, with comment http://codereview.chromium.org/10699006/diff/11001/tests/standalone/io/test_extension_test.dart File tests/standalone/io/test_extension_test.dart (right): http://codereview.chromium.org/10699006/diff/11001/tests/standalone/io/test_extension_test.dart#newcode10 tests/standalone/io/test_extension_test.dart:10: // The following import statements, hidden ...
8 years, 5 months ago (2012-06-29 12:32:11 UTC) #2
Bill Hesse
8 years, 5 months ago (2012-06-29 12:46:32 UTC) #3
http://codereview.chromium.org/10699006/diff/11001/tests/standalone/io/test_e...
File tests/standalone/io/test_extension_test.dart (right):

http://codereview.chromium.org/10699006/diff/11001/tests/standalone/io/test_e...
tests/standalone/io/test_extension_test.dart:21: // Make this a multitest so
that the test scripts run a copy of it in
You are write - if this is not a multitest, then we will know both the build
directory and the dart directory, and so we can copy all of the files manually. 
I will file a bug to redo this that way.

On 2012/06/29 12:32:11, Søren Gjesse wrote:
> I am not sure that I like the way you get this file,
test_extension_tester.dart
> and test_extension.dart copied into the generated_tests directory.
> 
> It is a way to get it running, but at least you should open a bug saying that
> this should be reconsidered and there should be another way to do this.
> 
> As you are already copying the native extension file couldn't you also just
copy
> the other files as well into some well known directory?

Powered by Google App Engine
This is Rietveld 408576698