Added crypto random-number generator

sync/util/nigori.cc

Index: sync/util/nigori.cc
diff --git a/sync/util/nigori.cc b/sync/util/nigori.cc
index f2ee83dffba3d0b9036957fc0e69e1f978d26a35..1ccd52d7783914a6791b3a8e48f9d42189cfa120 100644
--- a/sync/util/nigori.cc
+++ b/sync/util/nigori.cc
@@ -9,16 +9,15 @@
 
 #include "base/base64.h"
 #include "base/logging.h"
-#include "base/rand_util.h"
 #include "base/string_util.h"
 #include "base/sys_byteorder.h"
 #include "crypto/encryptor.h"
 #include "crypto/hmac.h"
+#include "crypto/random.h"
 #include "crypto/symmetric_key.h"
 
 using base::Base64Encode;
 using base::Base64Decode;
-using base::RandInt;
 using crypto::Encryptor;
 using crypto::HMAC;
 using crypto::SymmetricKey;
@@ -154,20 +153,13 @@ bool Nigori::Permute(Type type, const std::string& name,
   return Base64Encode(output, permuted);
 }
 
-std::string GenerateRandomString(size_t size) {
-  // TODO(albertb): Use a secure random function.
-  std::string random(size, 0);
-  for (size_t i = 0; i < size; ++i)
-    random[i] = RandInt(0, 0xff);
-  return random;
-}
-
 // Enc[Kenc,Kmac](value)
 bool Nigori::Encrypt(const std::string& value, std::string* encrypted) const {
   if (0U >= value.size())
     return false;
 
-  std::string iv = GenerateRandomString(kIvSize);
+  std::string iv(kIvSize, '\0');
+  crypto::RandBytes(&*iv.begin(), kIvSize);

[akalin, 2012/07/20 00:21:57]

why not have a crypto::RandBytesAsString also?

 
   Encryptor encryptor;
   if (!encryptor.Init(encryption_key_.get(), Encryptor::CBC, iv))