Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 10698159: Clean up WATCHLIST (Closed)

Created:
8 years, 5 months ago by gavinp
Modified:
8 years, 5 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, Nirnimesh
Visibility:
Public.

Description

Clean up WATCHLIST Most uses of the Kleene star in this file were doing nothing, and only contributing to making it harder to read. I've removed all the Kleene star use cases that I found confusing, and a comment at the top of the file to remind people not to reconfusify the file. R=nirnimesh@chromium.org BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146739

Patch Set 1 #

Patch Set 2 : merge to trunk #

Patch Set 3 : fix merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -147 lines) Patch
M WATCHLISTS View 1 2 6 chunks +149 lines, -147 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gavinp
Just something I saw as I was in the are. Nirnimesh, WDYT?
8 years, 5 months ago (2012-07-11 22:49:01 UTC) #1
Nirnimesh
LGTM. Thanks for the cleanup.
8 years, 5 months ago (2012-07-11 22:52:30 UTC) #2
gavinp
On 2012/07/11 22:52:30, Nirnimesh wrote: > LGTM. Thanks for the cleanup. I'll CQ this after ...
8 years, 5 months ago (2012-07-11 23:04:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/10698159/8001
8 years, 5 months ago (2012-07-14 14:50:27 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-14 15:52:50 UTC) #5
Change committed as 146739

Powered by Google App Engine
This is Rietveld 408576698