Switch about box to web ui on Windows.

chrome/browser/google/google_update.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/google/google_update.h"
 
 #include <atlbase.h>
 #include <atlcom.h>
 
 #include "base/bind.h"
@@ skipping 217 matching lines @@
 ////////////////////////////////////////////////////////////////////////////////
 // GoogleUpdate, public:
 
 GoogleUpdate::GoogleUpdate()
     : listener_(NULL) {
 }
 
 GoogleUpdate::~GoogleUpdate() {
 }
 
-void GoogleUpdate::CheckForUpdate(bool install_if_newer,
-                                  views::Widget* window) {
+void GoogleUpdate::CheckForUpdate(bool install_if_newer) {
   // We need to shunt this request over to InitiateGoogleUpdateCheck and have
   // it run in the file thread.
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&GoogleUpdate::InitiateGoogleUpdateCheck, this,
-                 install_if_newer, window, MessageLoop::current()));
+                 install_if_newer, MessageLoop::current()));
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // GoogleUpdate, private:
 
 void GoogleUpdate::InitiateGoogleUpdateCheck(bool install_if_newer,
-                                             views::Widget* window,
                                              MessageLoop* main_loop) {
   FilePath chrome_exe;
   if (!PathService::Get(base::DIR_EXE, &chrome_exe))
     NOTREACHED();
 
   GoogleUpdateErrorCode error_code = CanUpdateCurrentChrome(chrome_exe);
   if (error_code != GOOGLE_UPDATE_NO_ERROR) {
     main_loop->PostTask(
         FROM_HERE,
         base::Bind(&GoogleUpdate::ReportResults, this,
@@ skipping 25 matching lines @@
 
   if (InstallUtil::IsPerUserInstall(chrome_exe.value().c_str())) {
     hr = on_demand.CreateInstance(CLSID_OnDemandUserAppsClass);
   } else {
     // The Update operation needs Admin privileges for writing
     // to %ProgramFiles%. On Vista we need to elevate before instantiating
     // the updater instance.
     if (!install_if_newer) {
       hr = on_demand.CreateInstance(CLSID_OnDemandMachineAppsClass);
     } else {
-      HWND foreground_hwnd = NULL;
-      if (window != NULL) {
-        foreground_hwnd = window->GetNativeWindow();
-      }
-
       hr = CoCreateInstanceAsAdmin(CLSID_OnDemandMachineAppsClass,
-          IID_IGoogleUpdate, foreground_hwnd,
+          IID_IGoogleUpdate, GetForegroundWindow(),

[Ben Goodger (Google), 2012/07/09 22:28:01]

Will this always return the foreground-most window in the current
process/thread? What if this function is called when Chrome isn't active? Is
that possible?

[MAD, 2012/07/10 00:20:09]

Yes, but I think that's OK, it's just that the elevation prompt will be shown on
top of that other app... But maybe it's not what we want?

And note that this also has a small window of opportunity to have
GetForegroundWindow return NULL if we call it as we are losing activation
because the user switches to another app at that time... This would have the
side effect of having the elevation prompt not be shown in the foreground, which
I think is OK.. 

Although, I tried to confirm that there wouldn't be any other problems with
using another process' window as the owner of the elevation prompt, so I'll
change the code to use GetActiveWindow() in the UI thread...

           reinterpret_cast<void**>(on_demand.Receive()));
     }
     system_level = true;
   }
 
   if (hr != S_OK) {
     GoogleUpdateErrorCode error = GOOGLE_UPDATE_ONDEMAND_CLASS_NOT_FOUND;
     string16 error_code = base::StringPrintf(L"%d: 0x%x", error, hr);
     if (system_level)
       error_code += L" -- system level";
@@ skipping 89 matching lines @@
                                  MessageLoop* main_loop) {
   NOTREACHED() << "Communication with Google Update failed: " << hr
                << " error: " << error_code
                << ", message: " << error_message.c_str();
   main_loop->PostTask(
       FROM_HERE,
       base::Bind(&GoogleUpdate::ReportResults, this,
                  UPGRADE_ERROR, error_code, error_message));
   return false;
 }