rlz/lib/lib_values.cc - Issue 10698024: rlz: Change omnibox / homepage access points from C1/C2 to C5/C6 on mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rlz/lib/lib_values.cc

Issue 10698024: rlz: Change omnibox / homepage access points from C1/C2 to C5/C6 on mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: rlz/lib/lib_values.cc

diff --git a/rlz/lib/lib_values.cc b/rlz/lib/lib_values.cc

index 467e45683468172a9d2f40425fde007c8648be0d..f3b4448cca9c29dcc564e80f79073243727abac4 100644

--- a/rlz/lib/lib_values.cc

+++ b/rlz/lib/lib_values.cc

@@ -69,6 +69,8 @@ const char* GetAccessPointName(AccessPoint point) {

case GD_OUTLOOK: return "D4";

case CHROME_OMNIBOX: return "C1";

case CHROME_HOME_PAGE: return "C2";

+ case CHROME_MAC_OMNIBOX: return "C5";

+ case CHROME_MAC_HOME_PAGE: return "C6";

Roger Tawa OOO till Jul 10th 2012/07/03 18:11:09 Should keep these at lines 96 and 97, same order a

Nico 2012/07/03 18:18:08 Done.

case FFTB2_BOX: return "B2";

case FFTB3_BOX: return "B3";

case PINYIN_IME_BHO: return "N1";

@@ -93,8 +95,6 @@ const char* GetAccessPointName(AccessPoint point) {

case PARTNER_AP_3: return "V3";

case PARTNER_AP_4: return "V4";

case PARTNER_AP_5: return "V5";

- case UNDEFINED_AP_H: return "RH";

- case UNDEFINED_AP_I: return "RI";

case UNDEFINED_AP_J: return "RJ";

case UNDEFINED_AP_K: return "RK";

case UNDEFINED_AP_L: return "RL";

« chrome/browser/rlz/rlz.cc ('K') | « chrome/browser/rlz/rlz_unittest.cc ('k') | rlz/lib/rlz_enums.h » ('j') | no next file with comments »