Upstreaming Cygprofile for Android.

tools/cygprofile/README.chromium

Index: tools/cygprofile/README.chromium
diff --git a/tools/cygprofile/README.chromium b/tools/cygprofile/README.chromium
new file mode 100644
index 0000000000000000000000000000000000000000..ca90b6739647c7a127772f8351c6cd57d0570c93
--- /dev/null
+++ b/tools/cygprofile/README.chromium
@@ -0,0 +1,44 @@
+Name: CygProfiler instrumentation for -finstrument-functions
+Short Name: CygProfiler
+URL: http://www.logix.cz/michal/devel/CygProfiler/
+Version: 0
+Date: N/A
+Revision: N/A
+License: public domain
+License File: LICENSE
+Security Critical: No

[Steve Block, 2012/08/03 16:53:22]

Thanks for providing this metadata. Please add this directory to
ADDITIONAL_PATHS in tools/licenses.py to make sure it stays correct (see the
output of 'tools/licenses.py scan'.)

+
+Description:
+Implementation of instrumentation functions for use with gcc's
+-finstrument-functions option.
+
+Local Modifications:

[Steve Block, 2012/08/03 16:53:22]

Do these apply to the Android or 'regular' versions?

+09/07/2011: Original unmodified version of code added to third_party
+
+09/08/2011: cyg-profile.c was removed and replaced with the cyg-profile.cc file.
+The style has been changed to fit Google's style guide.  Logging and format
+changed to log only first entry of a function.  Logs virtual address of code
+section which contains profiled code, and logs timestamps of calls.  The
+implementation was also made thread-safe with the use of stdlib sets and a
+pthread mutex.
+
+01/23/2012: Android: enable profiling on first __cyg_profile_func_enter() call.
+This is useful to profile the large number of static initializers used
+by Chromium on this platform.
+
+07/03/2012:
+Moving third_party/cygprofile/ to base/android/third_party/cygprofile/.  This
+implementation is currently only being used by Android and is so different from
+the original version that it makes more sense to move to base/android/. There is
+yet another implementation of cygprofile in //tools/cygprofile/ which is being
+used by Chromium, that is also different from the open-source version, and
+different from the version used by Android.
+
+07/04/2012: Renaming base/android/third_party/cygprofile/ to cygprofile_startup
+since this version only collects profiling information from the first time a
+function is run.  This has been used to investigate ways to improve Chrome for
+Android startup time.
+
+07/18/2012: Renaming and moving //base/android/third_party/cygprofile_startup to

[Steve Block, 2012/08/03 16:53:22]

This history of file locations etc refers to the downstream Android tree, right?
I think this will be very confusing to a future Chromium developer, as they
won't be able to see any of this history. It's OK to describe the Android
history in the CL comments, but I think that for the purposes of this README, we
should consider the origin of the Android code to be this CL.

+//tools/cygprofile/cygprofile_android.h . Since there is already a version of
+Cygprofile at that directory used by Chromium.