Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5128)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 10697017: Tabs Extension: Implementation of tabs.duplicate api. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/tabs/tabs.cc ('K') | « chrome/browser/ui/browser_commands.h ('k') | chrome/common/extensions/api/tabs.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_commands.cc
===================================================================
--- chrome/browser/ui/browser_commands.cc (revision 150331)
+++ chrome/browser/ui/browser_commands.cc (working copy)
@@ -487,7 +487,7 @@
return contents && contents->GetController().GetLastCommittedEntry();
}
-void DuplicateTabAt(Browser* browser, int index) {
+TabContents* DuplicateTabAt(Browser* browser, int index) {
TabContents* contents = GetTabContentsAt(browser, index);
CHECK(contents);
TabContents* contents_dupe = contents->Clone();
@@ -536,6 +536,7 @@
SessionServiceFactory::GetForProfileIfExisting(browser->profile());
if (session_service)
session_service->TabRestored(contents_dupe, pinned);
+ return contents_dupe;
}
bool CanDuplicateTabAt(Browser* browser, int index) {
« chrome/browser/extensions/api/tabs/tabs.cc ('K') | « chrome/browser/ui/browser_commands.h ('k') | chrome/common/extensions/api/tabs.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698