Tabs Extension: Implementation of tabs.duplicate api.

chrome/browser/extensions/api/tabs/tabs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tabs/tabs.h"
 
 #include <algorithm>
 #include <limits>
 #include <vector>
 
@@ skipping 1083 matching lines @@
   // Return data about the newly created tab.
   if (has_callback()) {
     result_.reset(ExtensionTabUtil::CreateTabValue(
         params.target_contents->web_contents(),
         tab_strip, new_index));
   }
 
   return true;
 }
 
+bool DuplicateTabFunction::RunImpl() {
+  int tab_id = -1;
+  EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &tab_id));
+
+  Browser* browser = GetCurrentBrowser();
+  if (!browser) {
+    error_ = keys::kNoCurrentWindowError;
+    return false;
+  }
+
+  TabStripModel* tab_strip = NULL;
+  TabContents* contents = NULL;
+  int tab_index = -1;
+  if (!GetTabById(tab_id, profile(), include_incognito(),
+                  NULL, &tab_strip, &contents, &tab_index, &error_))

[Mihai Parparita -not on Chrome, 2012/07/03 22:57:18]

You need to pass in &browser instead of NULL here. There's no guarantee that the
tab being duplicated belongs to the current browser, so the tab index could
point do a different tab.

Also, if you use the browser that that is returned for the opening of the
duplicated tab, then you could remove the GetCurrentBrowser check entirely.

Finally, you may want to support an optional windowId parameter for the window
where the duplicated tab should be inserted. Though I suppose chrome.tabs.move
could be used with the return value, so it may not strictly be necessary.

[SanjoyPal, 2012/07/04 06:49:46]

Done. Let me know if we decide to support windowId parameter.

+    return false;
+
+  TabContents* new_contents = browser->DuplicateContentsAt(tab_index);
+  int new_index = tab_strip->GetIndexOfTabContents(new_contents);
+
+  // Return data about the newly created tab.
+  if (has_callback()) {
+    if (GetExtension()->HasAPIPermission(ExtensionAPIPermission::kTab)) {
+      result_.reset(ExtensionTabUtil::CreateTabValue(
+          new_contents->web_contents(),
+          tab_strip, new_index));
+    } else {
+      result_.reset(Value::CreateIntegerValue(
+          ExtensionTabUtil::GetTabId(new_contents->web_contents())));
+    }
+  }
+
+  return true;
+}
+
 bool GetTabFunction::RunImpl() {
   int tab_id = -1;
   EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &tab_id));
 
   TabStripModel* tab_strip = NULL;
   TabContents* contents = NULL;
   int tab_index = -1;
   if (!GetTabById(tab_id, profile(), include_incognito(),
                   NULL, &tab_strip, &contents, &tab_index, &error_))
     return false;
@@ skipping 710 matching lines @@
   // called for every API call the extension made.
   GotLanguage(language);
 }
 
 void DetectTabLanguageFunction::GotLanguage(const std::string& language) {
   result_.reset(Value::CreateStringValue(language.c_str()));
   SendResponse(true);
 
   Release();  // Balanced in Run()
 }