Tabs Extension: Implementation of tabs.duplicate api.

chrome/browser/extensions/extension_tab_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_TAB_UTIL_H__
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_TAB_UTIL_H__
 #pragma once
 
 #include <string>
 
@@ skipping 27 matching lines @@
                                    int *tab_id, std::string* error_message);
   static std::string GetTabStatusText(bool is_loading);
   static int GetWindowIdOfTab(const content::WebContents* web_contents);
   static base::ListValue* CreateTabList(const Browser* browser);
   static base::DictionaryValue* CreateTabValue(
       const content::WebContents* web_contents);
   static base::DictionaryValue* CreateTabValue(
       const content::WebContents* web_contents,
       TabStripModel* tab_strip,
       int tab_index);
+  static base::DictionaryValue* CreateTabValue(
+      const content::WebContents* web_contents,
+      TabStripModel* tab_strip,
+      int tab_index, bool has_permission);

[Aaron Boodman, 2012/08/07 01:03:25]

I would prefer an enum rather than the boolean param. Can you add:

enum PrivacyFlags {
  INCLUDE_PRIVACY_SENSITIVE_FIELDS,
  OMIT_PRIVACY_SENSITIVE_FIELDS
}

[SanjoyPal, 2012/08/14 11:14:13]

Done.

   // Create a tab value, overriding its kSelectedKey to the provided boolean.
   static base::DictionaryValue* CreateTabValueActive(
       const content::WebContents* web_contents,
       bool active);
 
   // Gets the |tab_strip_model| and |tab_index| for the given |web_contents|.
   static bool GetTabStripModel(const content::WebContents* web_contents,
                                TabStripModel** tab_strip_model,
                                int* tab_index);
   static bool GetDefaultTab(Browser* browser,
@@ skipping 16 matching lines @@
   // extension base, we decided it wasn't worth breaking existing extensions to
   // fix.
   static GURL ResolvePossiblyRelativeURL(const std::string& url_string,
       const extensions::Extension* extension);
 
   // Returns true if |url| is used for testing crashes.
   static bool IsCrashURL(const GURL& url);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_TAB_UTIL_H__