Make saving files from flash less annoying.

chrome/browser/ui/views/select_file_dialog_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/select_file_dialog.h"
 
 #include <windows.h>
 #include <commdlg.h>
 #include <shlobj.h>
 
@@ skipping 59 matching lines @@
       NOTREACHED();
       return false;
     }
 
     return metro_get_save_file_name(ofn) == TRUE;
   } else {
     return GetSaveFileName(ofn) == TRUE;
   }
 }
 
+// Distinguish directories from regular files.
+bool IsDirectory(const FilePath& path) {
+  base::PlatformFileInfo file_info;
+  return file_util::GetFileInfo(path, &file_info) ?
+      file_info.is_directory : file_util::EndsWithSeparator(path);
+}
+
 }  // namespace
 
 // This function takes the output of a SaveAs dialog: a filename, a filter and
 // the extension originally suggested to the user (shown in the dialog box) and
 // returns back the filename with the appropriate extension tacked on. If the
 // user requests an unknown extension and is not using the 'All files' filter,
 // the suggested extension will be appended, otherwise we will leave the
 // filename unmodified. |filename| should contain the filename selected in the
 // SaveAs dialog box and may include the path, |filter_selected| should be
 // '*.something', for example '*.*' or it can be blank (which is treated as
@@ skipping 235 matching lines @@
   save_as.lpstrCustomFilter = NULL;
   save_as.nMaxCustFilter = 0;
   save_as.nFilterIndex = *index;
   save_as.lpstrFile = file_name;
   save_as.nMaxFile = arraysize(file_name);
   save_as.lpstrFileTitle = NULL;
   save_as.nMaxFileTitle = 0;
 
   // Set up the initial directory for the dialog.
   std::wstring directory;
-  if (!suggested_name.empty())
-     directory = suggested_path.DirName().value();
+  if (!suggested_name.empty()) {
+    if (IsDirectory(suggested_path)) {
+      directory = suggested_path.value();
+      file_part.clear();
+    } else {
+      directory = suggested_path.DirName().value();
+    }
+  }
 
   save_as.lpstrInitialDir = directory.c_str();
   save_as.lpstrTitle = NULL;
   save_as.Flags = OFN_OVERWRITEPROMPT | OFN_EXPLORER | OFN_ENABLESIZING |
                   OFN_NOCHANGEDIR | OFN_PATHMUSTEXIST;
   save_as.lpstrDefExt = &def_ext[0];
   save_as.lCustData = NULL;
 
   if (base::win::GetVersion() < base::win::VERSION_VISTA) {
     // The save as on Windows XP remembers its last position,
@@ skipping 408 matching lines @@
   wchar_t filename[MAX_PATH];
   // According to http://support.microsoft.com/?scid=kb;en-us;222003&x=8&y=12,
   // The lpstrFile Buffer MUST be NULL Terminated.
   filename[0] = 0;
   // Define the dir in here to keep the string buffer pointer pointed to
   // ofn.lpstrInitialDir available during the period of running the
   // GetOpenFileName.
   FilePath dir;
   // Use lpstrInitialDir to specify the initial directory
   if (!path->empty()) {
-    bool is_dir;
-    base::PlatformFileInfo file_info;
-    if (file_util::GetFileInfo(*path, &file_info))
-      is_dir = file_info.is_directory;
-    else
-      is_dir = file_util::EndsWithSeparator(*path);
-    if (is_dir) {
+    if (IsDirectory(*path)) {
       ofn.lpstrInitialDir = path->value().c_str();
     } else {
       dir = path->DirName();
       ofn.lpstrInitialDir = dir.value().c_str();
       // Only pure filename can be put in lpstrFile field.
       base::wcslcpy(filename, path->BaseName().value().c_str(),
                     arraysize(filename));
     }
   }
 
@@ skipping 64 matching lines @@
       }
     }
   }
   return success;
 }
 
 // static
 SelectFileDialog* SelectFileDialog::Create(Listener* listener) {
   return new SelectFileDialogImpl(listener);
 }