Issue 10696145: Moving metrics to api/ .

Issue 10696145: Moving metrics to api/ . (Closed)

Created:
8 years, 5 months ago by vabr (Chromium)

Modified:
8 years, 5 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, MAD, mihaip-chromium-reviews_chromium.org, Ilya Sherman, jar (doing other things)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Moving metrics to api/ . BUG=101244 TEST=N/A, only moving code, no change in functionality Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146092

Patch Set 1 #

Patch Set 2 : Adjusting argument splitting #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Putting back "using" and updating WATCHLISTS #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -435 lines)			Patch
M	WATCHLISTS	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/extensions/api/metrics/metrics.h	View	1	4 chunks	+9 lines, -4 lines	0 comments	Download
A +	chrome/browser/extensions/api/metrics/metrics.cc	View	1 2 3	6 chunks	+19 lines, -15 lines	0 comments	Download
A +	chrome/browser/extensions/api/metrics/metrics_apitest.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_registry.cc	View		3 chunks	+10 lines, -10 lines	0 comments	Download
D	chrome/browser/extensions/extension_metrics_apitest.cc	View		1 chunk	+0 lines, -132 lines	0 comments	Download
D	chrome/browser/extensions/extension_metrics_module.h	View		1 chunk	+0 lines, -122 lines	0 comments	Download
D	chrome/browser/extensions/extension_metrics_module.cc	View		1 chunk	+0 lines, -148 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/metrics/test.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vabr (Chromium)

Hi Mat, Could you please review this? It is moving stuff to api/ + removing ...

8 years, 5 months ago (2012-07-10 13:01:52 UTC) #1

Ilya Sherman

Drive-by: Please also update the WATCHLIST entries (for metrics, at least)

8 years, 5 months ago (2012-07-10 18:04:06 UTC) #2

Matt Perry

Thanks for the cleanup. LGTM (though I'd prefer to put the using directives back) https://chromiumcodereview.appspot.com/10696145/diff/4001/chrome/browser/extensions/api/metrics/metrics.cc ...

8 years, 5 months ago (2012-07-10 19:18:17 UTC) #3

vabr (Chromium)

Thanks Matt and Ilya, Your comments have just been addressed. Since Matt approved of this ...

8 years, 5 months ago (2012-07-11 08:22:29 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/10696145/3011

8 years, 5 months ago (2012-07-11 08:22:47 UTC) #5

Change committed as 146092

Expand Messages | Collapse Messages