remoting/host: Rename Capturer to VideoFrameCapturer.

remoting/host: Rename Capturer to VideoFrameCapturer.

BUG=104542
R=wez@chromium.org,alexeypa@chromium.org

[tfarina, 2012-07-09 01:29:40]

Please, take a look.

Seriously, rietveld is being STUPID as always when is about git mv! 

Locally it shows as:

$ g st
# On branch remoting-host-capturer
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#	renamed:    remoting/host/capturer.h -> remoting/host/video_frame_capturer.h
#	renamed:    remoting/host/capturer_fake.cc ->
remoting/host/video_frame_capturer_fake.cc
#	renamed:    remoting/host/capturer_fake.h ->
remoting/host/video_frame_capturer_fake.h
#	renamed:    remoting/host/capturer_helper.cc ->
remoting/host/video_frame_capturer_helper.cc
#	renamed:    remoting/host/capturer_helper.h ->
remoting/host/video_frame_capturer_helper.h
#	renamed:    remoting/host/capturer_helper_unittest.cc ->
remoting/host/video_frame_capturer_helper_unittest.cc
#	renamed:    remoting/host/capturer_linux.cc ->
remoting/host/video_frame_capturer_linux.cc
#	renamed:    remoting/host/capturer_linux_unittest.cc ->
remoting/host/video_frame_capturer_linux_unittest.cc
#	renamed:    remoting/host/capturer_mac.mm ->
remoting/host/video_frame_capturer_mac.mm
#	renamed:    remoting/host/capturer_mac_unittest.cc ->
remoting/host/video_frame_capturer_mac_unittest.cc
#	renamed:    remoting/host/capturer_win.cc ->
remoting/host/video_frame_capturer_win.cc
#	renamed:    remoting/host/capturer_win_unittest.cc ->
remoting/host/video_frame_capturer_win_unittest.cc

So instead of those A besides the file, it should be A+. :/

[tfarina, 2012-07-11 04:14:24]

Putting Alexey, in case he has more time to review this. ;)

Thanks!

[tfarina, 2012-07-12 14:50:17]

Ping Wez, Alexey?

[Wez, 2012-07-12 15:59:22]

LGTM w/ nits.

Thanks for taking the time to do this. :)

http://codereview.chromium.org/10696134/diff/1045/remoting/host/video_frame_c...
File remoting/host/video_frame_capturer_linux.cc (right):

http://codereview.chromium.org/10696134/diff/1045/remoting/host/video_frame_c...
remoting/host/video_frame_capturer_linux.cc:18: #include
"remoting/host/video_frame_capturer_helper.h"
nit: move this below differ.h

http://codereview.chromium.org/10696134/diff/1045/remoting/host/video_frame_c...
File remoting/host/video_frame_capturer_linux_unittest.cc (right):

http://codereview.chromium.org/10696134/diff/1045/remoting/host/video_frame_c...
remoting/host/video_frame_capturer_linux_unittest.cc:9:
TEST(VideoFrameCapturerLinuxTest, Capture) {
nit: Let's remove this _unittest.cc, and the _win_unittest.cc, to make it
clearer that we don't currentl;y have coverage for them.

http://codereview.chromium.org/10696134/diff/1045/remoting/host/video_frame_c...
File remoting/host/video_frame_capturer_win.cc (right):

http://codereview.chromium.org/10696134/diff/1045/remoting/host/video_frame_c...
remoting/host/video_frame_capturer_win.cc:16: #include
"remoting/host/video_frame_capturer_helper.h"
nit: Move below differ.h

[alexeypa (please no reviews), 2012-07-18 20:44:54]

Are you going to commit this any time soon. I have another cleanup change that
will conflict with this one and it makes sense if it'll go after this one.

[tfarina, 2012-07-19 01:35:04]

On 2012/07/18 20:44:54, alexeypa wrote:
> Are you going to commit this any time soon. I have another cleanup change that
> will conflict with this one and it makes sense if it'll go after this one.

Yes. I'm going to land this today I hope!

[tfarina, 2012-07-19 02:46:22]

On 2012/07/19 01:35:04, tfarina wrote:
> On 2012/07/18 20:44:54, alexeypa wrote:
> > Are you going to commit this any time soon. I have another cleanup change
that
> > will conflict with this one and it makes sense if it'll go after this one.
> 
> Yes. I'm going to land this today I hope!

Unfortunately, no. I'm not going to land this. This is causing too much trouble
to me to land it, and I have less time to hack on it these days :-(

So I'm closing this.

[alexeypa (please no reviews), 2012-07-19 15:29:15]

On 2012/07/19 02:46:22, tfarina wrote:
> So I'm closing this.

Do you mind if I land it?

[tfarina, 2012-07-19 15:39:49]

On Thursday, July 19, 2012, wrote:

> On 2012/07/19 02:46:22, tfarina wrote:
>
>> So I'm closing this.
>>
>
> Do you mind if I land it?
>
> Nope. ;)

Could you just note in your patch description that I did the original CL?
And/or point to this CL?
I don't mind too much though :)

http://codereview.chromium.**org/10696134/<http://codereview.chromium.org/106...
>


-- 
Thiago