Replace GetEntryByResourceId with GetEntryByResourceIdAsync in search and file upload

Replace GetEntryByResourceId with GetEntryByResourceIdAsync in search and file upload

BUG=133957
TEST=unit tests pass.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146148

[achuithb, 2012-07-11 00:14:26]

Two more instances of GetEntryByResourceId replaced with async versions.

[hshi1, 2012-07-11 00:23:44]

http://codereview.chromium.org/10696131/diff/7002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10696131/diff/7002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system.cc:453: callback.Run(error,
scoped_ptr<std::vector<SearchResultInfo> >(results));
Is it possible that |callback| is null? It seems that if callback is null, we
may leak memory associated with the std::vector<SearchResultInfo> |results|,
because the scoped_ptr would not be initialized with the |results|.

[achuithb, 2012-07-11 00:38:10]

http://codereview.chromium.org/10696131/diff/7002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10696131/diff/7002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system.cc:453: callback.Run(error,
scoped_ptr<std::vector<SearchResultInfo> >(results));
On 2012/07/11 00:23:44, hshi1 wrote:
> Is it possible that |callback| is null? It seems that if callback is null, we
> may leak memory associated with the std::vector<SearchResultInfo> |results|,
> because the scoped_ptr would not be initialized with the |results|.

I don't think the callback would be NULL since we're doing a lot of work to
collect the results. This is Toni's code so I'm not sure. I've added code to
defend against this potential leak.

[hshi1, 2012-07-11 00:42:18]

lgtm

[achuithb, 2012-07-11 00:42:52]

On 2012/07/11 00:42:18, hshi1 wrote:
> lgtm

Thanks. Satoru-san, let me know if you're planning to review this.

[commit-bot: I haz the power, 2012-07-11 16:43:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/10696131/5

[commit-bot: I haz the power, 2012-07-11 18:08:08]

Change committed as 146148