Add test to verify we can cancel the GetUserMedia request right after sending the request

issue 135043 tells that WebRtc could crash the browser if we remove the request right after generating it.
This test is crash/no-crash regression test which addresses the issue.

BUG=135043
TEST=chrome/test/functional/webrtc_call.py

[no longer working on chromium, 2012-07-04 14:05:29]

Please review, thanks.

BR,
/SX

[phoglund_chromium, 2012-07-04 14:20:57]

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/data/webrt...
File chrome/test/data/webrtc/getusermedia.js (right):

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/data/webrt...
chrome/test/data/webrtc/getusermedia.js:41: */
I think it makes more sense to call this guy ReloadWebPage. Then write a comment
in the test itself which says "cancel the request by reloading the web page".
Then this function makes a lot more sense on its own since someone could really
call it independent of a getUserMedia request.

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/data/webrt...
chrome/test/data/webrtc/getusermedia.js:44: 
Reloading page

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/data/webrt...
chrome/test/data/webrtc/getusermedia.js:45: debug("Cancelling GetUserMedia
request.");
ok-reloaded-page

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/data/webrt...
chrome/test/data/webrtc/getusermedia.js:85: gRequestWebcamAndMicrophoneResult =
'failed-with-error-' + error.code;
Not sure what happened on this line?

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/functional...
File chrome/test/functional/webrtc_call.py (right):

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/functional...
chrome/test/functional/webrtc_call.py:147: def
testCancelGetUserMediaRequest(self):
The first line in the docstring must not have any line breaks in it (it's sort
of the short description for the method). Maybe you can write something like
"""Check we don't crash on a quick reload after getUserMedia.

This test will quickly reload the page after running getUserMedia. This crashed
the browser before the fix for crbug.com/135043.
"""

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/functional...
chrome/test/functional/webrtc_call.py:153: self.AppendTab(pyauto.GURL(url))
You did reproduce the crash with the test, right? Note that the javascript
calling here will mean that the reload will be noticeably delayed compared to
the bug's test page, since we need to go through the PyAuto test layers to call
your new reload function.

[no longer working on chromium, 2012-07-05 14:05:19]

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/data/webrt...
File chrome/test/data/webrtc/getusermedia.js (right):

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/data/webrt...
chrome/test/data/webrtc/getusermedia.js:41: */
On 2012/07/04 14:20:58, phoglund wrote:
> I think it makes more sense to call this guy ReloadWebPage. Then write a
comment
> in the test itself which says "cancel the request by reloading the web page".
> Then this function makes a lot more sense on its own since someone could
really
> call it independent of a getUserMedia request.

Done.

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/data/webrt...
chrome/test/data/webrtc/getusermedia.js:44: 
On 2012/07/04 14:20:58, phoglund wrote:
> Reloading page

Done.

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/data/webrt...
chrome/test/data/webrtc/getusermedia.js:45: debug("Cancelling GetUserMedia
request.");
On 2012/07/04 14:20:58, phoglund wrote:
> ok-reloaded-page

Done.

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/data/webrt...
chrome/test/data/webrtc/getusermedia.js:85: gRequestWebcamAndMicrophoneResult =
'failed-with-error-' + error.code;
On 2012/07/04 14:20:58, phoglund wrote:
> Not sure what happened on this line?

Not sure, it does not change anything in my editor.

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/functional...
File chrome/test/functional/webrtc_call.py (right):

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/functional...
chrome/test/functional/webrtc_call.py:147: def
testCancelGetUserMediaRequest(self):
On 2012/07/04 14:20:58, phoglund wrote:
> The first line in the docstring must not have any line breaks in it (it's sort
> of the short description for the method). Maybe you can write something like
> """Check we don't crash on a quick reload after getUserMedia.
> 
> This test will quickly reload the page after running getUserMedia. This
crashed
> the browser before the fix for crbug.com/135043.
> """

Done.

https://chromiumcodereview.appspot.com/10696115/diff/1/chrome/test/functional...
chrome/test/functional/webrtc_call.py:153: self.AppendTab(pyauto.GURL(url))
On 2012/07/04 14:20:58, phoglund wrote:
> You did reproduce the crash with the test, right? Note that the javascript
> calling here will mean that the reload will be noticeably delayed compared to
> the bug's test page, since we need to go through the PyAuto test layers to
call
> your new reload function.

Thanks for pointing this out. I just double checked, the crash I saw happened in
a later state, which hit a DCHECK in MediaStreamDeviceSettings::PostResponse(),
not exactly the same place as how it is described in issue 135043, but they
belong to the same issue.
And I also tried a bit on call getUserMedia and reload in sequence, but I could
not reproduce any crash, it looks like that if we call reload too soon, we are
able to catch up the request and avoid crashing.

[Nirnimesh, 2012-07-12 14:07:01]

https://chromiumcodereview.appspot.com/10696115/diff/10001/chrome/test/data/w...
File chrome/test/data/webrtc/getusermedia.js (right):

https://chromiumcodereview.appspot.com/10696115/diff/10001/chrome/test/data/w...
chrome/test/data/webrtc/getusermedia.js:40: * This function realods the web page
which will cancel the previous
This function reloads -> Reload

https://chromiumcodereview.appspot.com/10696115/diff/10001/chrome/test/functi...
File chrome/test/functional/webrtc_call.py (right):

https://chromiumcodereview.appspot.com/10696115/diff/10001/chrome/test/functi...
chrome/test/functional/webrtc_call.py:160: self.assertEquals('ok-reloaded-page',
self.ExecuteJavascript(
You don't need javascript to reload the page. You can make direct pyauto calls.
See navigation.py for examples.

[phoglund_chromium, 2012-08-03 12:34:47]

On 2012/07/12 14:07:01, Nirnimesh wrote:
>
https://chromiumcodereview.appspot.com/10696115/diff/10001/chrome/test/data/w...
> File chrome/test/data/webrtc/getusermedia.js (right):
> 
>
https://chromiumcodereview.appspot.com/10696115/diff/10001/chrome/test/data/w...
> chrome/test/data/webrtc/getusermedia.js:40: * This function realods the web
page
> which will cancel the previous
> This function reloads -> Reload
> 
>
https://chromiumcodereview.appspot.com/10696115/diff/10001/chrome/test/functi...
> File chrome/test/functional/webrtc_call.py (right):
> 
>
https://chromiumcodereview.appspot.com/10696115/diff/10001/chrome/test/functi...
> chrome/test/functional/webrtc_call.py:160:
self.assertEquals('ok-reloaded-page',
> self.ExecuteJavascript(
> You don't need javascript to reload the page. You can make direct pyauto
calls.
> See navigation.py for examples.

I've taken over this patch. I'm incorporating a fixed version of this code in
http://codereview.chromium.org/10830159/. We can drop this CL later.