sync: Track validity of about:sync fields

chrome/browser/sync/profile_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service.h"
 
 #include <cstddef>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 935 matching lines @@
              data_type_manager_.get() &&
              data_type_manager_->state() != DataTypeManager::CONFIGURED) {
     return "Datatypes not fully initialized";
   } else if (ShouldPushChanges()) {
     return "Sync service initialized";
   } else {
     return "Status unknown: Internal error?";
   }
 }
 
-SyncBackendHost::Status ProfileSyncService::QueryDetailedSyncStatus() {
+bool ProfileSyncService::QueryDetailedSyncStatus(
+    SyncBackendHost::Status* result) {
   if (backend_.get() && backend_initialized_) {
-    return backend_->GetDetailedStatus();
+    *result = backend_->GetDetailedStatus();
+    return true;
   } else {
     SyncBackendHost::Status status;
     status.sync_protocol_error = last_actionable_error_;
-    return status;
+    *result = status;
+    return false;
   }
 }
 
 const GoogleServiceAuthError& ProfileSyncService::GetAuthError() const {
   return last_auth_error_;
 }
 
 bool ProfileSyncService::FirstSetupInProgress() const {
   return !HasSyncSetupCompleted() && setup_in_progress_;
 }
@@ skipping 749 matching lines @@
   // See http://stackoverflow.com/questions/6224121/is-new-this-myclass-undefined-behaviour-after-directly-calling-the-destru.
   ProfileSyncService* old_this = this;
   this->~ProfileSyncService();
   new(old_this) ProfileSyncService(
       new ProfileSyncComponentsFactoryImpl(profile,
                                            CommandLine::ForCurrentProcess()),
       profile,
       signin,
       behavior);
 }