sync: Track validity of about:sync fields

chrome/browser/sync/about_sync_util_unittest.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/sync/about_sync_util.h"
+#include "chrome/browser/sync/profile_sync_service_mock.h"
+#include "content/public/test/test_browser_thread.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using ::testing::NiceMock;

[akalin, 2012/07/12 00:01:55]

namespace sync_ui_util { namespace { } } ?

[rlarocque, 2012/07/12 01:02:20]

Done, mostly.  I left the using declarations out of the namespace.

+using ::testing::Return;
+using ::testing::_;
+using content::BrowserThread;
+
+TEST(SyncUIUtilTest, ConstructAboutInformationWithUnrecoverableErrorTest) {
+  MessageLoopForUI message_loop;
+  content::TestBrowserThread ui_thread(BrowserThread::UI, &message_loop);
+  scoped_ptr<Profile> profile(
+      ProfileSyncServiceMock::MakeSignedInTestingProfile());
+  NiceMock<ProfileSyncServiceMock> service(profile.get());
+
+  // Will be released when the dictionary is destroyed

[akalin, 2012/07/12 00:01:55]

hunh?

[rlarocque, 2012/07/12 01:02:20]

That was there when I copied this test out of sync_ui_util_unittest.cc.  I don't
know what it's referring to, either.

I'll remove it.

+  string16 str(ASCIIToUTF16("none"));
+
+  browser_sync::SyncBackendHost::Status status;
+
+  EXPECT_CALL(service, HasSyncSetupCompleted())
+              .WillOnce(Return(true));
+  EXPECT_CALL(service, QueryDetailedSyncStatus(_))
+              .WillOnce(Return(false));
+
+  EXPECT_CALL(service, HasUnrecoverableError())
+              .WillRepeatedly(Return(true));
+
+  EXPECT_CALL(service, GetLastSyncedTimeString())
+              .WillOnce(Return(str));
+
+  scoped_ptr<DictionaryValue> strings(
+      sync_ui_util::ConstructAboutInformation(&service));
+
+  EXPECT_TRUE(strings->HasKey("unrecoverable_error_detected"));
+}