Hide the main window when Set-As-Default dialog is present.

chrome/browser/ui/startup/startup_browser_creator_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/startup_browser_creator_impl.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
 #include "base/environment.h"
@@ skipping 700 matching lines @@
     first_tab = false;
   }
   if (!chrome::GetActiveWebContents(browser)) {
     // TODO: this is a work around for 110909. Figure out why it's needed.
     if (!browser->tab_count())
       browser->AddBlankTab(true);
     else
       chrome::ActivateTabAt(browser, 0, false);
   }
 
-  browser->window()->Show();
-  // TODO(jcampan): http://crbug.com/8123 we should not need to set the initial
-  //                focus explicitly.
-  chrome::GetActiveWebContents(browser)->GetView()->SetInitialFocus();
+  // If we expect modal dialog to show, showing the browser has to be supressed
+  // for now. The start sequence will then take care of showing it.
+  bool as_first_run = is_first_run_ ||

[grt (UTC plus 2), 2012/07/05 20:08:47]

as discussed in person, i think it's cleaner to move this policy logic out into
ChromeBrowserMainParts::PreCreateThreadsImpl within the if (is_first_run_) block
so that some sort of "Start Hidden" bit is flipped on the creator when the
conditions are right for such.  then this can become more like:

  if (!browser_creator_->ShouldStartHidden()) {
    ...
  }

[motek., 2012/08/08 14:28:35]

Moved to the creator, but as a simple setter/getter.

+      command_line_.HasSwitch(switches::kFirstRun);
+  if (!chrome::ExpectDefaultBrowserPromptDialog(profile_, as_first_run)) {
+    browser->window()->Show();
+    // TODO(jcampan): http://crbug.com/8123 we should not need to set the
+    //                initial focus explicitly.
+    chrome::GetActiveWebContents(browser)->GetView()->SetInitialFocus();
+  }
 
   return browser;
 }
 
 void StartupBrowserCreatorImpl::AddInfoBarsIfNecessary(
     Browser* browser,
     chrome::startup::IsProcessStartup is_process_startup) {
   if (!browser || !profile_ || browser->tab_count() == 0)
     return;
 
@@ skipping 125 matching lines @@
         // New:
         prefs->GetString(prefs::kHomePage),
         prefs->GetBoolean(prefs::kHomePageIsNewTabPage),
         prefs->GetBoolean(prefs::kShowHomeButton),
         // Backup:
         backup_homepage,
         backup_homepage_is_ntp,
         backup_show_home_button));
   }
 }