Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: chrome/browser/ui/webui/options2/chromeos/display_options_handler.cc

Issue 10696002: ASH: Use virtual screen coordinates in Display::bounds() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ash/ash.gyp ('K') | « ash/shell.cc ('k') | ui/aura/monitor_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options2/chromeos/display_options_handler.cc
diff --git a/chrome/browser/ui/webui/options2/chromeos/display_options_handler.cc b/chrome/browser/ui/webui/options2/chromeos/display_options_handler.cc
index 835b742fc43befd89b2a2f936b4022101522a83d..730c845003df688a81093c3d0cfe9c44240401fc 100644
--- a/chrome/browser/ui/webui/options2/chromeos/display_options_handler.cc
+++ b/chrome/browser/ui/webui/options2/chromeos/display_options_handler.cc
@@ -104,10 +104,10 @@ void DisplayOptionsHandler::SendDisplayInfo() {
base::ListValue displays;
for (size_t i = 0; i < monitor_manager->GetNumDisplays(); ++i) {
- const gfx::Display& display = monitor_manager->GetDisplayAt(i);
- const gfx::Rect& bounds = display.bounds();
+ const gfx::Display* display = monitor_manager->GetDisplayAt(i);
Ben Goodger (Google) 2012/06/27 15:32:52 i get confused by the various ways you return disp
oshima 2012/06/27 21:00:06 crbug.com/122863 I'm planning to consolidate gfx:
+ const gfx::Rect& bounds = display->bounds();
base::DictionaryValue* js_display = new base::DictionaryValue();
- js_display->SetDouble("id", display.id());
+ js_display->SetDouble("id", display->id());
js_display->SetDouble("x", bounds.x());
js_display->SetDouble("y", bounds.y());
js_display->SetDouble("width", bounds.width());
« ash/ash.gyp ('K') | « ash/shell.cc ('k') | ui/aura/monitor_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698